<p>Pau Espin Pedrol <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11571">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Neels Hofmeyr: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">UHDDevice: setRxGain on chan 0 when using multi-arfcn<br><br>When using multi-arfcn feature, several logical channels (arfcn) are multiplxed<br>into one physical transceiver, as can be seen in<br>uhd_device::set_channels.<br><br>As a result, when multi-arfcn is enabled some properties are actually<br>shared for those logical channels, and internally mapped to the first<br>(only existing) channel, and per-channel internal array variables are allocated<br>accordingly (size() == 1).<br><br>When setting RxGain, we need to set the correct existing physical<br>channel. Same check is done in getRxGain, and then we apply the RxGain correctly and<br>we avoid outputing an error "Requested non-existent channel" immediatelly after.<br><br>Change-Id: I5b02bb1ef6450dc48be7b8058d96a5691847d3cc<br>---<br>M Transceiver52M/device/uhd/UHDDevice.cpp<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/device/uhd/UHDDevice.cpp b/Transceiver52M/device/uhd/UHDDevice.cpp</span><br><span>index c30f3a7..3db09a8 100644</span><br><span>--- a/Transceiver52M/device/uhd/UHDDevice.cpp</span><br><span>+++ b/Transceiver52M/device/uhd/UHDDevice.cpp</span><br><span>@@ -486,6 +486,9 @@</span><br><span> </span><br><span> double uhd_device::setRxGain(double db, size_t chan)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+   if (iface == MULTI_ARFCN)</span><br><span style="color: hsl(120, 100%, 40%);">+             chan = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  if (chan >= rx_gains.size()) {</span><br><span>            LOGC(DDEV, ALERT) << "Requested non-existent channel " << chan;</span><br><span>                return 0.0f;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11571">change 11571</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11571"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I5b02bb1ef6450dc48be7b8058d96a5691847d3cc </div>
<div style="display:none"> Gerrit-Change-Number: 11571 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>