<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11841">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts: Disable PCU related tests if PCU socket not configured<br><br>With some real HW setups, there's no PCU (osmo-pcu) available locally,<br>for instance when using a sysmobts, or when using a nanoBTS. There's no<br>need to waste time and generate extra output by running this tests in<br>this case.<br><br>Furthermore, some tests seem to crash sometimes in that setup, probably<br>due to using invalid fd (-1):<br>MTC@801a0da9866a: Setting RSL_SYSTEM_INFO_4 (4): '31061C62F224002A4740E50400'O<br> /osmo-ttcn3-hacks/bts/BTS_Tests: Segmentation fault occurred<br>/usr/lib/titan/libttcn3-parallel-dynamic.so(_Z14signal_handleri+0xa3)[0x7f0c33b48073]<br>/lib/x86_64-linux-gnu/libc.so.6(+0x33060)[0x7f0c321aa060]<br>/osmo-ttcn3-hacks/bts/UD_PT.so(_ZN12UD__PortType15UD__PT_PROVIDER13outgoing_sendERKN9UD__Types14UD__send__dataE+0xf0)[0x7f0c349e42f8]<br>/osmo-ttcn3-hacks/bts/PCUIF_CodecPort.so(_ZN16PCUIF__CodecPort16PCUIF__CODEC__PT4sendERKNS_17PCUIF__send__dataERK9COMPONENT+0x19e)[0x7f0c37e1731a]<br>/osmo-ttcn3-hacks/bts/PCUIF_CodecPort.so(_ZN16PCUIF__CodecPort16PCUIF__CODEC__PT4sendERKNS_26PCUIF__send__data_templateE+0x5f)[0x7f0c37e174f7]<br>/osmo-ttcn3-hacks/bts/BTS_Tests.so(_ZN10BTS__Tests20f__TC__pcu__act__reqERK7INTEGERS2_S2_RK7BOOLEAN+0x411)[0x7f0c3eec3210]<br>/osmo-ttcn3-hacks/bts/BTS_Tests.so(_ZN10BTS__Tests28testcase_TC__pcu__deact__reqEbd+0x15d)[0x7f0c3eec4f27]<br>/osmo-ttcn3-hacks/bts/BTS_Tests.so(+0xfb65d)[0x7f0c3eeef65d]<br>/usr/lib/titan/libttcn3-parallel-dynamic.so(_ZN11Module_List15execute_controlEPKc+0x1c)[0x7f0c33af3fbc]<br><br>Change-Id: I773c7ec52dd8532bf160e92ffefc8d936ca55de2<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 21 insertions(+), 17 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/41/11841/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index cde9562..753d89b 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -4186,23 +4186,27 @@</span><br><span>   execute( TC_ipa_crcx_mdcx_mdcx_dlcx_not_active() );</span><br><span>  execute( TC_ipa_crcx_sdcch_not_active() );</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  execute( TC_pcu_act_req() );</span><br><span style="color: hsl(0, 100%, 40%);">-    execute( TC_pcu_act_req_wrong_ts() );</span><br><span style="color: hsl(0, 100%, 40%);">-   execute( TC_pcu_act_req_wrong_bts() );</span><br><span style="color: hsl(0, 100%, 40%);">-  execute( TC_pcu_act_req_wrong_trx() );</span><br><span style="color: hsl(0, 100%, 40%);">-  execute( TC_pcu_deact_req() );</span><br><span style="color: hsl(0, 100%, 40%);">-  execute( TC_pcu_deact_req_wrong_ts() );</span><br><span style="color: hsl(0, 100%, 40%);">- execute( TC_pcu_ver_si13() );</span><br><span style="color: hsl(0, 100%, 40%);">-   execute( TC_pcu_data_req_wrong_bts() );</span><br><span style="color: hsl(0, 100%, 40%);">- execute( TC_pcu_data_req_wrong_trx() );</span><br><span style="color: hsl(0, 100%, 40%);">- execute( TC_pcu_data_req_wrong_ts() );</span><br><span style="color: hsl(0, 100%, 40%);">-  execute( TC_pcu_data_req_ts_inactive() );</span><br><span style="color: hsl(0, 100%, 40%);">-       execute( TC_pcu_data_req_pdtch() );</span><br><span style="color: hsl(0, 100%, 40%);">-     execute( TC_pcu_data_req_ptcch() );</span><br><span style="color: hsl(0, 100%, 40%);">-     execute( TC_pcu_data_req_agch() );</span><br><span style="color: hsl(0, 100%, 40%);">-      execute( TC_pcu_data_req_imm_ass_pch() );</span><br><span style="color: hsl(0, 100%, 40%);">-       execute( TC_pcu_rach_content() );</span><br><span style="color: hsl(0, 100%, 40%);">-       execute( TC_pcu_paging_from_rsl() );</span><br><span style="color: hsl(120, 100%, 40%);">+  if (mp_pcu_socket != "") {</span><br><span style="color: hsl(120, 100%, 40%);">+          execute( TC_pcu_act_req() );</span><br><span style="color: hsl(120, 100%, 40%);">+          execute( TC_pcu_act_req_wrong_ts() );</span><br><span style="color: hsl(120, 100%, 40%);">+         execute( TC_pcu_act_req_wrong_bts() );</span><br><span style="color: hsl(120, 100%, 40%);">+                execute( TC_pcu_act_req_wrong_trx() );</span><br><span style="color: hsl(120, 100%, 40%);">+                execute( TC_pcu_deact_req() );</span><br><span style="color: hsl(120, 100%, 40%);">+                execute( TC_pcu_deact_req_wrong_ts() );</span><br><span style="color: hsl(120, 100%, 40%);">+               execute( TC_pcu_ver_si13() );</span><br><span style="color: hsl(120, 100%, 40%);">+         execute( TC_pcu_data_req_wrong_bts() );</span><br><span style="color: hsl(120, 100%, 40%);">+               execute( TC_pcu_data_req_wrong_trx() );</span><br><span style="color: hsl(120, 100%, 40%);">+               execute( TC_pcu_data_req_wrong_ts() );</span><br><span style="color: hsl(120, 100%, 40%);">+                execute( TC_pcu_data_req_ts_inactive() );</span><br><span style="color: hsl(120, 100%, 40%);">+             execute( TC_pcu_data_req_pdtch() );</span><br><span style="color: hsl(120, 100%, 40%);">+           execute( TC_pcu_data_req_ptcch() );</span><br><span style="color: hsl(120, 100%, 40%);">+           execute( TC_pcu_data_req_agch() );</span><br><span style="color: hsl(120, 100%, 40%);">+            execute( TC_pcu_data_req_imm_ass_pch() );</span><br><span style="color: hsl(120, 100%, 40%);">+             execute( TC_pcu_rach_content() );</span><br><span style="color: hsl(120, 100%, 40%);">+             execute( TC_pcu_paging_from_rsl() );</span><br><span style="color: hsl(120, 100%, 40%);">+  } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              log("PCU socket path not available, skipping PCU tests");</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span> </span><br><span>        execute( TC_dyn_osmo_pdch_act_deact() );</span><br><span>     execute( TC_dyn_osmo_pdch_unsol_deact() );</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11841">change 11841</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11841"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I773c7ec52dd8532bf160e92ffefc8d936ca55de2 </div>
<div style="display:none"> Gerrit-Change-Number: 11841 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>