<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11559">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BSC LCLS: add bts-loop tests<br><br>Add basic establishment and teardown tests for 'bts-loop' mode of LCLS:<br>* add explicit vty init for desired LCLS kind<br>* add necessary IPA RSL MDCX functions<br>* explicitly pass LCLS kind as a parameter to shared<br> functions (defaulting to 'mgw-loop')<br><br>Change-Id: I40e786b430591899c722d99d685db26efa868508<br>Related: OS#3659<br>---<br>M bsc/BSC_Tests.ttcn<br>M bsc/BSC_Tests_LCLS.ttcn<br>M bsc/expected-results.xml<br>3 files changed, 127 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 21ec0ff..13535ce 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -289,7 +289,7 @@</span><br><span> vc_MGCP.start(MGCP_Emulation.main(ops, mgcp_pars, id));</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-private function f_init_vty(charstring id := "foo") runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+function f_init_vty(charstring id := "foo") runs on test_CT {</span><br><span> if (BSCVTY.checkstate("Mapped")) {</span><br><span> /* skip initialization if already executed once */</span><br><span> return;</span><br><span>diff --git a/bsc/BSC_Tests_LCLS.ttcn b/bsc/BSC_Tests_LCLS.ttcn</span><br><span>index 585059e..c401206 100644</span><br><span>--- a/bsc/BSC_Tests_LCLS.ttcn</span><br><span>+++ b/bsc/BSC_Tests_LCLS.ttcn</span><br><span>@@ -36,6 +36,7 @@</span><br><span> import from MGCP_Emulation all;</span><br><span> import from MGCP_Templates all;</span><br><span> import from SDP_Types all;</span><br><span style="color: hsl(120, 100%, 40%);">+import from Native_Functions all;</span><br><span> </span><br><span> import from Osmocom_CTRL_Functions all;</span><br><span> import from Osmocom_CTRL_Types all;</span><br><span>@@ -226,13 +227,20 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-private function f_lcls_init(integer nr_bts := 1) runs on lcls_test_CT</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_lcls_init(boolean bts_mode := false, integer nr_bts := 1) runs on lcls_test_CT</span><br><span> {</span><br><span> var default d;</span><br><span> </span><br><span> d := activate(as_ignore());</span><br><span> f_init(nr_bts, true);</span><br><span> f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_vty();</span><br><span style="color: hsl(120, 100%, 40%);">+ if (bts_mode == true) {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config(BSCVTY, "msc", "lcls-mode bts-loop");</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config(BSCVTY, "msc", "lcls-mode mgw-loop");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span> </span><br><span> </span><br><span>@@ -273,12 +281,62 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-private function f_tc_lcls_gcr_bway_connect(boolean hr) runs on lcls_test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_tc_lcls_ack_rsl_mdcx(RSL_Message rsl_msg, boolean send_on_a) runs on lcls_test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var boolean fixme_unused;</span><br><span style="color: hsl(120, 100%, 40%);">+ var RSL_IE_Body ie;</span><br><span style="color: hsl(120, 100%, 40%);">+ var RslChannelNr chan_nr;</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint16_t conn_id;</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint7_t rtp_pt := 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ var HostName host;</span><br><span style="color: hsl(120, 100%, 40%);">+ var PortNumber port_num;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (f_rsl_find_ie(rsl_msg, RSL_IE_CHAN_NR, ie) == true) {</span><br><span style="color: hsl(120, 100%, 40%);">+ chan_nr := ie.chan_nr;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("Unable to find chan# in ", rsl_msg);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fixme_unused := f_rsl_find_ie(rsl_msg, RSL_IE_IPAC_CONN_ID, ie);</span><br><span style="color: hsl(120, 100%, 40%);">+ conn_id := ie.ipa_conn_id;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* mandatory fields */</span><br><span style="color: hsl(120, 100%, 40%);">+ fixme_unused := f_rsl_find_ie(rsl_msg, RSL_IE_IPAC_REMOTE_IP, ie);</span><br><span style="color: hsl(120, 100%, 40%);">+ host := f_inet_ntoa(int2oct(ie.ipa_remote_ip, 4));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fixme_unused := f_rsl_find_ie(rsl_msg, RSL_IE_IPAC_REMOTE_PORT, ie);</span><br><span style="color: hsl(120, 100%, 40%);">+ port_num := ie.ipa_remote_port;</span><br><span style="color: hsl(120, 100%, 40%);">+ log("LCLS IPA MDCX for lchan ", chan_nr, " connection ID ", conn_id, " host ", host, ":", port_num);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* optional */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (f_rsl_find_ie(rsl_msg, RSL_IE_IPAC_RTP_PAYLOAD, ie)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ rtp_pt := ie.ipa_rtp_pt;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (send_on_a == true) {</span><br><span style="color: hsl(120, 100%, 40%);">+ CONN_A.send(ts_RSL_IPA_MDCX_ACK(chan_nr, conn_id, oct2int(f_inet_addr(host)), port_num, rtp_pt));</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ CONN_B.send(ts_RSL_IPA_MDCX_ACK(chan_nr, conn_id, oct2int(f_inet_addr(host)), port_num, rtp_pt));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_tc_lcls_recv_ls_exp_rsl() runs on lcls_test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var RSL_Message rsl_msg;</span><br><span style="color: hsl(120, 100%, 40%);">+ interleave {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] CONN_A.receive(tr_BSSMAP_LclsNotificationSts(LCLS_STS_not_yet_ls)) {}</span><br><span style="color: hsl(120, 100%, 40%);">+ [] CONN_A.receive(tr_BSSMAP_LclsNotificationSts(LCLS_STS_locally_switched)) {}</span><br><span style="color: hsl(120, 100%, 40%);">+ [] CONN_B.receive(LclsCompSync:LCLS_COMP_SYNC_ASS_COMPL) {}</span><br><span style="color: hsl(120, 100%, 40%);">+ [] CONN_A.receive(tr_RSL_IPA_MDCX(?, ?)) -> value rsl_msg {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tc_lcls_ack_rsl_mdcx(rsl_msg, true)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_tc_lcls_gcr_bway_connect(boolean hr, boolean bts_mode := false) runs on lcls_test_CT {</span><br><span> var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars);</span><br><span> var TestHdlrParams pars_b;</span><br><span> var MSC_ConnHdlr vc_conn;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_lcls_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_lcls_init(bts_mode);</span><br><span> </span><br><span> if (hr == true) {</span><br><span> pars_a.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecHR}));</span><br><span>@@ -288,6 +346,7 @@</span><br><span> pars_a.lcls.gcr := valueof(ts_GCR('010203'O, '0405'O, '060708090a'O));</span><br><span> pars_a.lcls.cfg := LCLS_CFG_both_way;</span><br><span> pars_a.lcls.csc := LCLS_CSC_connect;</span><br><span style="color: hsl(120, 100%, 40%);">+ pars_a.lcls.adjust_cx_exp := not bts_mode;</span><br><span> pars_b := pars_a;</span><br><span> </span><br><span> /* first call is not possible to be LS (no second leg yet) */</span><br><span>@@ -299,7 +358,11 @@</span><br><span> </span><br><span> CONN_A.receive(LclsCompSync:LCLS_COMP_SYNC_ASS_COMPL);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_tc_lcls_recv_ls_exp_mgcp();</span><br><span style="color: hsl(120, 100%, 40%);">+ if (bts_mode == true) {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tc_lcls_recv_ls_exp_rsl();</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tc_lcls_recv_ls_exp_mgcp();</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> f_lcls_test_fini();</span><br><span> }</span><br><span>@@ -311,7 +374,17 @@</span><br><span> </span><br><span> /* Send an ASSIGNMENT REQ with LCLS GCR+CFG+CSC; expect connect both-way (half rate) */</span><br><span> testcase TC_lcls_gcr_bway_connect_hr() runs on lcls_test_CT {</span><br><span style="color: hsl(0, 100%, 40%);">- f_tc_lcls_gcr_bway_connect(true)</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tc_lcls_gcr_bway_connect(true)</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* BTS-loop: send an ASSIGNMENT REQ with LCLS GCR+CFG+CSC; expect connect both-way (full rate)*/</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_lcls_bts_gcr_bway_connect() runs on lcls_test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tc_lcls_gcr_bway_connect(false, true)</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* BTS-loop: send an ASSIGNMENT REQ with LCLS GCR+CFG+CSC; expect connect both-way (half rate) */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_lcls_bts_gcr_bway_connect_hr() runs on lcls_test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tc_lcls_gcr_bway_connect(true, true)</span><br><span> }</span><br><span> </span><br><span> /* Unless explicitly enabled, osmo-bsc will avoid LCLSs when the codecs or rates</span><br><span>@@ -470,6 +543,26 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+private function f_lcls_sts_rsl(BIT4 expected_status) runs on lcls_test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var RSL_Message rsl_msg;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ interleave {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] CONN_B.receive(tr_BSSMAP_LclsConnCtrlAck(tr_BSSMAP_IE_LclsSts(expected_status)));</span><br><span style="color: hsl(120, 100%, 40%);">+ [] CONN_A.receive(tr_BSSMAP_LclsNotificationSts(expected_status));</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ [] CONN_A.receive(RSL_Message:?) -> value rsl_msg {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("f_lcls_sts_rsl CONN_A top RSL is ", rsl_msg)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Ex. placeholder to catch any RSL message */</span><br><span style="color: hsl(120, 100%, 40%);">+ [] CONN_A.receive(tr_RSL_IPA_MDCX(?, ?)) -> value rsl_msg {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tc_lcls_ack_rsl_mdcx(rsl_msg, true)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] CONN_B.receive(tr_RSL_IPA_MDCX(?, ?)) -> value rsl_msg {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tc_lcls_ack_rsl_mdcx(rsl_msg, false)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Send an ASSIGNMENT REQ with "do not connect" and enable later using LCLS CTRL */</span><br><span> testcase TC_lcls_gcr_bway_dont_connect_csc() runs on lcls_test_CT {</span><br><span> var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars);</span><br><span>@@ -523,18 +616,18 @@</span><br><span> return valueof(ts_MDCX_ACK(mdcx.line.trans_id, conn_id, sdp_out));</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Establish LCLS "connect" followed by a MSC-initiated break */</span><br><span style="color: hsl(0, 100%, 40%);">-testcase TC_lcls_connect_break() runs on lcls_test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_lcls_connect_break(boolean bts_mode := false) runs on lcls_test_CT {</span><br><span> var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars);</span><br><span> var TestHdlrParams pars_b;</span><br><span> var MSC_ConnHdlr vc_conn;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_lcls_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_lcls_init(bts_mode);</span><br><span> </span><br><span> pars_a.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR}));</span><br><span> pars_a.lcls.gcr := valueof(ts_GCR('010203'O, '0405'O, '060708090a'O));</span><br><span> pars_a.lcls.cfg := LCLS_CFG_both_way;</span><br><span> pars_a.lcls.csc := LCLS_CSC_connect;</span><br><span style="color: hsl(120, 100%, 40%);">+ pars_a.lcls.adjust_cx_exp := not bts_mode;</span><br><span> pars_b := pars_a;</span><br><span> </span><br><span> /* first call is not possible to be LS (no second leg yet) */</span><br><span>@@ -546,7 +639,11 @@</span><br><span> f_lcls_test_init(pars_a, pars_b);</span><br><span> CONN_A.receive(LclsCompSync:LCLS_COMP_SYNC_ASS_COMPL);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_tc_lcls_recv_ls_exp_mgcp()</span><br><span style="color: hsl(120, 100%, 40%);">+ if (bts_mode == true) {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tc_lcls_recv_ls_exp_rsl();</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_tc_lcls_recv_ls_exp_mgcp();</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> /* request LS release on "A" side; call continues to be locally switched */</span><br><span> CONN_A.send(ts_BSSMAP_LclsConnCtrl(omit, ts_BSSMAP_IE_LclsCsc(LCLS_CSC_release_lcls)));</span><br><span>@@ -556,11 +653,24 @@</span><br><span> /* request LS release on "B" side; call LS is released */</span><br><span> CONN_B.send(ts_BSSMAP_LclsConnCtrl(omit, ts_BSSMAP_IE_LclsCsc(LCLS_CSC_release_lcls)));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_lcls_sts_mgcp(LCLS_STS_no_longer_ls)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (bts_mode == true) {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_lcls_sts_rsl(LCLS_STS_no_longer_ls);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_lcls_sts_mgcp(LCLS_STS_no_longer_ls);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> f_lcls_test_fini();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Establish LCLS "connect" followed by a MSC-initiated break */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_lcls_connect_break() runs on lcls_test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_lcls_connect_break()</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_lcls_bts_connect_break() runs on lcls_test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_lcls_connect_break(true)</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Establish LCLS "connect" followed by a SCCP-level release of one leg */</span><br><span> testcase TC_lcls_connect_clear() runs on lcls_test_CT {</span><br><span> var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars);</span><br><span>@@ -640,7 +750,9 @@</span><br><span> execute( TC_lcls_connect_break() );</span><br><span> execute( TC_lcls_connect_clear() );</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_lcls_bts_gcr_bway_connect() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_lcls_bts_gcr_bway_connect_hr() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_lcls_bts_connect_break() );</span><br><span> }</span><br><span> </span><br><span> </span><br><span>diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml</span><br><span>index cd808d8..ff50990 100644</span><br><span>--- a/bsc/expected-results.xml</span><br><span>+++ b/bsc/expected-results.xml</span><br><span>@@ -94,4 +94,7 @@</span><br><span> <testcase classname='BSC_Tests_LCLS' name='TC_lcls_gcr_bway_dont_connect_csc' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests_LCLS' name='TC_lcls_connect_break' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests_LCLS' name='TC_lcls_connect_clear' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='BSC_Tests_LCLS' name='TC_lcls_bts_gcr_bway_connect' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='BSC_Tests_LCLS' name='TC_lcls_bts_gcr_bway_connect_hr' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='BSC_Tests_LCLS' name='TC_lcls_bts_connect_break' time='MASKED'/></span><br><span> </testsuite></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11559">change 11559</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11559"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I40e786b430591899c722d99d685db26efa868508 </div>
<div style="display:none"> Gerrit-Change-Number: 11559 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Vadim Yanitskiy <axilirator@gmail.com> </div>