<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11558">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">LCLS: explicitly check for *CX adjustment<br><br>Previously the expectations for number of CRCX and MDCX messages from<br>MGW was adjusted unconditionally for LCLS tests. However this is only<br>necessary for MGW-loop type of LCLS. Use explicit variable (with default<br>value preserving current behavior) to decide whether to apply this<br>adjustment or not. This simplifies support for other kinds of LCLS<br>loops.<br><br>Change-Id: I07b2c56991977b5e80c372a5b8338f348f14c076<br>Related: OS#3659<br>---<br>M bsc/MSC_ConnectionHandler.ttcn<br>1 file changed, 6 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>index f96e74a..0ea73a0 100644</span><br><span>--- a/bsc/MSC_ConnectionHandler.ttcn</span><br><span>+++ b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>@@ -408,7 +408,9 @@</span><br><span>    BIT4 cfg optional,</span><br><span>   /* LCLS Connection Status Control */</span><br><span>         BIT4 csc optional,</span><br><span style="color: hsl(0, 100%, 40%);">-      BIT4 exp_sts optional</span><br><span style="color: hsl(120, 100%, 40%);">+ BIT4 exp_sts optional,</span><br><span style="color: hsl(120, 100%, 40%);">+        /* Whether to adjust *cx_seen_exp for LCLS tests */</span><br><span style="color: hsl(120, 100%, 40%);">+   boolean adjust_cx_exp</span><br><span> }</span><br><span> </span><br><span> type record TestHdlrParamsHandover {</span><br><span>@@ -446,7 +448,8 @@</span><br><span>                 gcr := omit,</span><br><span>                 cfg := omit,</span><br><span>                 csc := omit,</span><br><span style="color: hsl(0, 100%, 40%);">-            exp_sts := omit</span><br><span style="color: hsl(120, 100%, 40%);">+               exp_sts := omit,</span><br><span style="color: hsl(120, 100%, 40%);">+              adjust_cx_exp := true</span><br><span>        },</span><br><span>   handover := omit,</span><br><span>    aoip := true</span><br><span>@@ -992,7 +995,7 @@</span><br><span>    * is mgcp_conn[1]. The BSC performs this operation already before the</span><br><span>        * assignment complete is generated. This means we expect another MDCX</span><br><span>        * at mgcp_conn[1] when LCLS is expected. */</span><br><span style="color: hsl(0, 100%, 40%);">-    if (ispresent(exp_ass_cpl.pdu.bssmap.assignmentComplete.lCLS_BSS_Status.lCLS_BSS_StatusValue)) {</span><br><span style="color: hsl(120, 100%, 40%);">+      if (g_pars.lcls.adjust_cx_exp and ispresent(exp_ass_cpl.pdu.bssmap.assignmentComplete.lCLS_BSS_Status.lCLS_BSS_StatusValue)) {</span><br><span>               if (valueof(exp_ass_cpl.pdu.bssmap.assignmentComplete.lCLS_BSS_Status.lCLS_BSS_StatusValue) == LCLS_STS_locally_switched) {</span><br><span>                  g_media.mgcp_conn[1].mdcx_seen_exp := g_media.mgcp_conn[1].mdcx_seen_exp + 1;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11558">change 11558</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11558"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I07b2c56991977b5e80c372a5b8338f348f14c076 </div>
<div style="display:none"> Gerrit-Change-Number: 11558 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>