<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11632">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Neels Hofmeyr: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">prevent potential NULL dereference in virtbts's tx_tchh_fn<br><br>If chan_state->ongoing_facch is set, this code's logic<br>suggests that both msg_facch and msg_tch could be NULL.<br>Don't dereference msg_tch unconditionally.<br><br>Change-Id: Icf5584396c5b925d55ca9380dd4f869ae5d72da3<br>Related: CID#172047<br>---<br>M src/osmo-bts-virtual/scheduler_virtbts.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-virtual/scheduler_virtbts.c b/src/osmo-bts-virtual/scheduler_virtbts.c</span><br><span>index 2248afc..25f6583 100644</span><br><span>--- a/src/osmo-bts-virtual/scheduler_virtbts.c</span><br><span>+++ b/src/osmo-bts-virtual/scheduler_virtbts.c</span><br><span>@@ -463,7 +463,7 @@</span><br><span>    if (msg_facch) {</span><br><span>             tx_to_virt_um(l1t, tn, fn, chan, msg_facch);</span><br><span>                 msgb_free(msg_tch);</span><br><span style="color: hsl(0, 100%, 40%);">-     } else</span><br><span style="color: hsl(120, 100%, 40%);">+        } else if (msg_tch)</span><br><span>          tx_to_virt_um(l1t, tn, fn, chan, msg_tch);</span><br><span> </span><br><span> send_burst:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11632">change 11632</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11632"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Icf5584396c5b925d55ca9380dd4f869ae5d72da3 </div>
<div style="display:none"> Gerrit-Change-Number: 11632 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Pau Espin Pedrol <pespin@sysmocom.de> </div>