<p>Max has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11816">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mobile: add header for MS' MNCC functions<br><br>This simplifies adding new functions and re-using them from other parts<br>of the code.<br><br>Change-Id: Ibad400a99afe052f011f54fc706836b6bf89f4b9<br>---<br>M src/host/layer23/include/osmocom/bb/mobile/Makefile.am<br>A src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h<br>M src/host/layer23/src/mobile/mnccms.c<br>M src/host/layer23/src/mobile/vty_interface.c<br>4 files changed, 12 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/16/11816/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/include/osmocom/bb/mobile/Makefile.am b/src/host/layer23/include/osmocom/bb/mobile/Makefile.am</span><br><span>index 12cf24b..8e4be1a 100644</span><br><span>--- a/src/host/layer23/include/osmocom/bb/mobile/Makefile.am</span><br><span>+++ b/src/host/layer23/include/osmocom/bb/mobile/Makefile.am</span><br><span>@@ -1,3 +1,3 @@</span><br><span> noinst_HEADERS = gsm322.h gsm480_ss.h gsm411_sms.h gsm48_cc.h gsm48_mm.h \</span><br><span>             gsm48_rr.h mncc.h settings.h subscriber.h support.h \</span><br><span style="color: hsl(0, 100%, 40%);">-           transaction.h vty.h mncc_sock.h primitives.h</span><br><span style="color: hsl(120, 100%, 40%);">+          transaction.h vty.h mncc_sock.h mncc_ms.h primitives.h</span><br><span>diff --git a/src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h b/src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h</span><br><span>new file mode 100644</span><br><span>index 0000000..49ce1a4</span><br><span>--- /dev/null</span><br><span>+++ b/src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h</span><br><span>@@ -0,0 +1,9 @@</span><br><span style="color: hsl(120, 100%, 40%);">+#pragma once</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int mncc_call(struct osmocom_ms *ms, char *number);</span><br><span style="color: hsl(120, 100%, 40%);">+int mncc_hangup(struct osmocom_ms *ms);</span><br><span style="color: hsl(120, 100%, 40%);">+int mncc_answer(struct osmocom_ms *ms);</span><br><span style="color: hsl(120, 100%, 40%);">+int mncc_hold(struct osmocom_ms *ms);</span><br><span style="color: hsl(120, 100%, 40%);">+int mncc_retrieve(struct osmocom_ms *ms, int number);</span><br><span style="color: hsl(120, 100%, 40%);">+int mncc_dtmf(struct osmocom_ms *ms, char *dtmf);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>diff --git a/src/host/layer23/src/mobile/mnccms.c b/src/host/layer23/src/mobile/mnccms.c</span><br><span>index 9be9c8f..9f58112 100644</span><br><span>--- a/src/host/layer23/src/mobile/mnccms.c</span><br><span>+++ b/src/host/layer23/src/mobile/mnccms.c</span><br><span>@@ -30,15 +30,14 @@</span><br><span> #include <osmocom/bb/common/logging.h></span><br><span> #include <osmocom/bb/common/osmocom_data.h></span><br><span> #include <osmocom/bb/mobile/mncc.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bb/mobile/mncc_ms.h></span><br><span> #include <osmocom/bb/mobile/vty.h></span><br><span> </span><br><span> static uint32_t new_callref = 1;</span><br><span> static LLIST_HEAD(call_list);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void mncc_set_cause(struct gsm_mncc *data, int loc, int val);</span><br><span> static int dtmf_statemachine(struct gsm_call *call, struct gsm_mncc *mncc);</span><br><span> static void timeout_dtmf(void *arg);</span><br><span style="color: hsl(0, 100%, 40%);">-int mncc_answer(struct osmocom_ms *ms);</span><br><span> </span><br><span> /*</span><br><span>  * support functions</span><br><span>diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c</span><br><span>index 12c32a5..a0ad993 100644</span><br><span>--- a/src/host/layer23/src/mobile/vty_interface.c</span><br><span>+++ b/src/host/layer23/src/mobile/vty_interface.c</span><br><span>@@ -35,6 +35,7 @@</span><br><span> #include <osmocom/bb/common/networks.h></span><br><span> #include <osmocom/bb/common/gps.h></span><br><span> #include <osmocom/bb/mobile/mncc.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bb/mobile/mncc_ms.h></span><br><span> #include <osmocom/bb/mobile/transaction.h></span><br><span> #include <osmocom/bb/mobile/vty.h></span><br><span> #include <osmocom/bb/mobile/app_mobile.h></span><br><span>@@ -43,13 +44,6 @@</span><br><span> #include <osmocom/vty/telnet_interface.h></span><br><span> #include <osmocom/vty/misc.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-int mncc_call(struct osmocom_ms *ms, char *number);</span><br><span style="color: hsl(0, 100%, 40%);">-int mncc_hangup(struct osmocom_ms *ms);</span><br><span style="color: hsl(0, 100%, 40%);">-int mncc_answer(struct osmocom_ms *ms);</span><br><span style="color: hsl(0, 100%, 40%);">-int mncc_hold(struct osmocom_ms *ms);</span><br><span style="color: hsl(0, 100%, 40%);">-int mncc_retrieve(struct osmocom_ms *ms, int number);</span><br><span style="color: hsl(0, 100%, 40%);">-int mncc_dtmf(struct osmocom_ms *ms, char *dtmf);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> extern struct llist_head ms_list;</span><br><span> extern struct llist_head active_connections;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11816">change 11816</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11816"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ibad400a99afe052f011f54fc706836b6bf89f4b9 </div>
<div style="display:none"> Gerrit-Change-Number: 11816 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>