<p>Max has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11814">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">l1l2 interface: use LOGP for socket errors<br><br>Log via LOGP() like the rest of the file instead of fprintf() for<br>consistency. While at it, also print error cause.<br><br>Change-Id: Id205bcd9bdb7c3e4b96493d50be8381a6fa80ac6<br>---<br>M src/host/layer23/src/common/l1l2_interface.c<br>M src/host/layer23/src/common/sap_interface.c<br>2 files changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/14/11814/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/src/common/l1l2_interface.c b/src/host/layer23/src/common/l1l2_interface.c</span><br><span>index b366d51..c07b0a1 100644</span><br><span>--- a/src/host/layer23/src/common/l1l2_interface.c</span><br><span>+++ b/src/host/layer23/src/common/l1l2_interface.c</span><br><span>@@ -109,7 +109,8 @@</span><br><span> </span><br><span>  rc = osmo_sock_unix_init_ofd(&ms->l2_wq.bfd, SOCK_STREAM, 0, socket_path, OSMO_SOCK_F_CONNECT);</span><br><span>       if (rc < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-                fprintf(stderr, "Failed to create unix domain socket %s\n", socket_path);</span><br><span style="color: hsl(120, 100%, 40%);">+           LOGP(DL1C, LOGL_ERROR, "Failed to create unix domain socket %s: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                   socket_path, strerror(-rc));</span><br><span>            return rc;</span><br><span>   }</span><br><span> </span><br><span>diff --git a/src/host/layer23/src/common/sap_interface.c b/src/host/layer23/src/common/sap_interface.c</span><br><span>index cab3c6b..936beb3 100644</span><br><span>--- a/src/host/layer23/src/common/sap_interface.c</span><br><span>+++ b/src/host/layer23/src/common/sap_interface.c</span><br><span>@@ -503,7 +503,8 @@</span><br><span> </span><br><span>     rc = osmo_sock_unix_init_ofd(&ms->sap_wq.bfd, SOCK_STREAM, 0, socket_path, OSMO_SOCK_F_CONNECT);</span><br><span>      if (rc < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-                fprintf(stderr, "Failed to create unix domain socket %s\n", socket_path);</span><br><span style="color: hsl(120, 100%, 40%);">+           LOGP(DSAP, LOGL_ERROR, "Failed to create unix domain socket %s: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                   socket_path, strerror(-rc));</span><br><span>            ms->sap_entity.sap_state = SAP_SOCKET_ERROR;</span><br><span>              return rc;</span><br><span>   }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11814">change 11814</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11814"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id205bcd9bdb7c3e4b96493d50be8381a6fa80ac6 </div>
<div style="display:none"> Gerrit-Change-Number: 11814 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>