<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11780">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm29118: add value strings for SGSAP IEI<br><br>The value strings for the SGSAP IEI are missing, lets add a set of value<br>strings and a function to retrieve them.<br><br>Change-Id: I2787303174f74ffba86675bce2c12f680d8ea708<br>Related: OS#3615<br>---<br>M include/osmocom/gsm/protocol/gsm_29_118.h<br>M src/gsm/gsm29118.c<br>M src/gsm/libosmogsm.map<br>3 files changed, 40 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/11780/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/protocol/gsm_29_118.h b/include/osmocom/gsm/protocol/gsm_29_118.h</span><br><span>index c344f04..bf210ad 100644</span><br><span>--- a/include/osmocom/gsm/protocol/gsm_29_118.h</span><br><span>+++ b/include/osmocom/gsm/protocol/gsm_29_118.h</span><br><span>@@ -74,7 +74,10 @@</span><br><span> SGSAP_IE_ADDL_PAGING_INDICATORS = 0x26,</span><br><span> SGSAP_IE_TMSI_BASED_NRI_CONT = 0x27,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+const struct value_string sgsap_iei_names[];</span><br><span style="color: hsl(120, 100%, 40%);">+static inline const char *sgsap_iei_name(enum sgsap_iei iei) {</span><br><span style="color: hsl(120, 100%, 40%);">+ return get_value_string(sgsap_iei_names, iei);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> /* TS 29.118 Section 9.4.2 */</span><br><span> enum sgsap_eps_lu_type {</span><br><span>diff --git a/src/gsm/gsm29118.c b/src/gsm/gsm29118.c</span><br><span>index de625a9..3898be6 100644</span><br><span>--- a/src/gsm/gsm29118.c</span><br><span>+++ b/src/gsm/gsm29118.c</span><br><span>@@ -32,6 +32,41 @@</span><br><span> { 0, NULL }</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+const struct value_string sgsap_iei_names[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_IMSI, "IMSI" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_VLR_NAME, "VLR-NAME" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_TMSI, "TMSI" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_LAI, "LAI" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_CHAN_NEEDED, "CHAN-NEEDED" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_EMLPP_PRIORITY, "EMLPP-PRIORITY" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_TMSI_STATUS, "TMSI-STATUS" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_SGS_CAUSE, "SGS-CAUSE" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_MME_NAME, "MME-NAME" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_EPS_LU_TYPE, "EPS-LU-TYPE" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_GLOBAL_CN_ID, "GLOBAL-CN-ID" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_MOBILE_ID, "MOBILE-ID" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_REJECT_CAUSE, "REJECT-CAUSE" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_IMSI_DET_EPS_TYPE, "IMSI-DET-EPS-TYPE" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_IMSI_DET_NONEPS_TYPE, "IMSI-DET-NONEPS-TYPE" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_IMEISV, "IMEISV" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_NAS_MSG_CONTAINER, "NAS-MSG-CONTAINER" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_MM_INFO, "MM-INFO" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_ERR_MSG, "ERR-MSG" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_CLI, "CLI" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_LCS_CLIENT_ID, "LCS-CLIENT-ID" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_LCS_INDICATOR, "LCS-INDICATOR" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_SS_CODE, "SS-CODE" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_SERVICE_INDICATOR, "SERVICE-INDICATOR" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_UE_TIMEZONE, "UE-TIMEZONE" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_MS_CLASSMARK2, "MS-CLASSMARK2" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_TAI, "TAI" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_EUTRAN_CGI, "EUTRAN-CGI" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_UE_EMM_MODE, "UE-EMM-MODE" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_ADDL_PAGING_INDICATORS, "ADDL-PAGING-INDICATORS" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { SGSAP_IE_TMSI_BASED_NRI_CONT, "TMSI-BASED-NRI-CONT" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { 0, NULL }</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> const struct value_string sgsap_eps_lu_type_names[] = {</span><br><span> { SGSAP_EPS_LUT_IMSI_ATTACH, "IMSI Attach" },</span><br><span> { SGSAP_EPS_LUT_NORMAL, "Normal" },</span><br><span>diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map</span><br><span>index 4813e13..6234d94 100644</span><br><span>--- a/src/gsm/libosmogsm.map</span><br><span>+++ b/src/gsm/libosmogsm.map</span><br><span>@@ -512,6 +512,7 @@</span><br><span> osmo_oap_client_register;</span><br><span> </span><br><span> sgsap_msg_type_names;</span><br><span style="color: hsl(120, 100%, 40%);">+sgsap_iei_names;</span><br><span> sgsap_eps_lu_type_names;</span><br><span> sgsap_ismi_det_eps_type_names;</span><br><span> sgsap_ismi_det_noneps_type_names;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11780">change 11780</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11780"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2787303174f74ffba86675bce2c12f680d8ea708 </div>
<div style="display:none"> Gerrit-Change-Number: 11780 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>