<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11670">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lchan: set cause for 4 instances of release_in_error = true<br><br>Make sure some RSL cause is set.<br><br>Change-Id: I372ade9fc58919fbf858ce14caab8a0a22dbb083<br>---<br>M src/osmo-bsc/lchan_fsm.c<br>M src/osmo-bsc/lchan_rtp_fsm.c<br>2 files changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index c3790e5..71b40c1 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -1056,6 +1056,7 @@</span><br><span>     case LCHAN_EV_RSL_CHAN_ACTIV_ACK:</span><br><span>            /* A late Chan Activ ACK? Release. */</span><br><span>                lchan->release.in_error = true;</span><br><span style="color: hsl(120, 100%, 40%);">+            lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING;</span><br><span>            lchan_fsm_state_chg(LCHAN_ST_WAIT_RF_RELEASE_ACK);</span><br><span>           return;</span><br><span> </span><br><span>@@ -1067,6 +1068,7 @@</span><br><span>  case LCHAN_EV_RSL_RF_CHAN_REL_ACK:</span><br><span>           /* A late Release ACK? */</span><br><span>            lchan->release.in_error = true;</span><br><span style="color: hsl(120, 100%, 40%);">+            lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING;</span><br><span>            lchan_fsm_state_chg(LCHAN_ST_WAIT_AFTER_ERROR);</span><br><span>              /* TODO: we used to do this only for sysmobts:</span><br><span>                       int do_free = is_sysmobts_v2(ts->trx->bts);</span><br><span>@@ -1291,6 +1293,7 @@</span><br><span> </span><br><span>        default:</span><br><span>             lchan->release.in_error = true;</span><br><span style="color: hsl(120, 100%, 40%);">+            lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING;</span><br><span>            lchan_fail("Timeout");</span><br><span>             return 0;</span><br><span>    }</span><br><span>diff --git a/src/osmo-bsc/lchan_rtp_fsm.c b/src/osmo-bsc/lchan_rtp_fsm.c</span><br><span>index e3e68e5..aaba563 100644</span><br><span>--- a/src/osmo-bsc/lchan_rtp_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_rtp_fsm.c</span><br><span>@@ -725,6 +725,7 @@</span><br><span> {</span><br><span>    struct gsm_lchan *lchan = lchan_rtp_fi_lchan(fi);</span><br><span>    lchan->release.in_error = true;</span><br><span style="color: hsl(120, 100%, 40%);">+    lchan->release.rsl_error_cause = RSL_ERR_EQUIPMENT_FAIL;</span><br><span>  lchan_rtp_fail("Timeout");</span><br><span>         return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11670">change 11670</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11670"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I372ade9fc58919fbf858ce14caab8a0a22dbb083 </div>
<div style="display:none"> Gerrit-Change-Number: 11670 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>