<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11742">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">coverity: gscon_forget_lchan: squelch forward-null<br><br>conn->fi should actually never be NULL, they are allocated and discarded<br>simultaneously. So check its null from the start and remove some conditions<br>below, to remove the coverity warning.<br><br>Related: CID 189671<br>Change-Id: I62354aa998832131c86535f39a29294000114adc<br>---<br>M src/osmo-bsc/bsc_subscr_conn_fsm.c<br>1 file changed, 3 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>index 0dd21d9..d2ca03e 100644</span><br><span>--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>@@ -672,14 +672,12 @@</span><br><span> </span><br><span>    /* Log for both lchan FSM and conn FSM to ease reading the log in case of problems */</span><br><span>        if (detach_label) {</span><br><span style="color: hsl(0, 100%, 40%);">-             if (conn->fi)</span><br><span style="color: hsl(0, 100%, 40%);">-                        LOGPFSML(conn->fi, LOGL_DEBUG, "conn detaches lchan %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                          lchan->fi? osmo_fsm_inst_name(lchan->fi) : gsm_lchan_name(lchan));</span><br><span style="color: hsl(120, 100%, 40%);">+             LOGPFSML(conn->fi, LOGL_DEBUG, "conn detaches lchan %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                        lchan->fi? osmo_fsm_inst_name(lchan->fi) : gsm_lchan_name(lchan));</span><br><span> </span><br><span>                if (lchan->fi)</span><br><span>                    LOGPFSML(lchan->fi, LOGL_DEBUG, "conn %s detaches lchan (%s)\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                            conn->fi? osmo_fsm_inst_name(conn->fi) : "(conn without FSM)",</span><br><span style="color: hsl(0, 100%, 40%);">-                          detach_label);</span><br><span style="color: hsl(120, 100%, 40%);">+                                osmo_fsm_inst_name(conn->fi), detach_label);</span><br><span>     }</span><br><span> </span><br><span>        if (conn->fi->state != ST_CLEARING</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11742">change 11742</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11742"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I62354aa998832131c86535f39a29294000114adc </div>
<div style="display:none"> Gerrit-Change-Number: 11742 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>