<p>Stefan Sperling has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11729">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix bogus assertion in encode_comp_field()<br><br>Fix an obvious logic bug in an assertion in encode_comp_field().<br><br>Found by: Neels<br><br>Change-Id: If6f3598cd6da4643ff2214e21c0d21f6eff0eb67<br>---<br>M src/gprs/gprs_sndcp_xid.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/29/11729/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/gprs_sndcp_xid.c b/src/gprs/gprs_sndcp_xid.c</span><br><span>index 8f844b5..09e21f5 100644</span><br><span>--- a/src/gprs/gprs_sndcp_xid.c</span><br><span>+++ b/src/gprs/gprs_sndcp_xid.c</span><br><span>@@ -443,7 +443,7 @@</span><br><span>     OSMO_ASSERT(comp_field->entity <= 0x1f);</span><br><span> </span><br><span>   /* Check if the algorithm number is within bounds */</span><br><span style="color: hsl(0, 100%, 40%);">-    OSMO_ASSERT(comp_field->algo >= 0 || comp_field->algo <= 0x1f);</span><br><span style="color: hsl(120, 100%, 40%);">+   OSMO_ASSERT(comp_field->algo >= 0 && comp_field->algo <= 0x1f);</span><br><span> </span><br><span>      /* Zero out buffer */</span><br><span>        memset(dst, 0, dst_maxlen);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11729">change 11729</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11729"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If6f3598cd6da4643ff2214e21c0d21f6eff0eb67 </div>
<div style="display:none"> Gerrit-Change-Number: 11729 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>