<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11742">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">coverity: gscon_forget_lchan: squelch forward-null<br><br>conn->fi should actually never be NULL, they are allocated and discarded<br>simultaneously. So check its null from the start and remove some conditions<br>below, to remove the coverity warning.<br><br>The warning was introduced in recent 946d1fb5c7f4a593567b407222c9235f8fac7a59<br><br>Related: CID 189671<br>Change-Id: I62354aa998832131c86535f39a29294000114adc<br>---<br>M src/osmo-bsc/bsc_subscr_conn_fsm.c<br>1 file changed, 4 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/42/11742/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>index 4d6521f..3a4ae7e 100644</span><br><span>--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>@@ -652,7 +652,7 @@</span><br><span> void gscon_forget_lchan(struct gsm_subscriber_connection *conn, struct gsm_lchan *lchan)</span><br><span> {</span><br><span>     const char *detach_label = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-        if (!conn)</span><br><span style="color: hsl(120, 100%, 40%);">+    if (!conn || !conn->fi)</span><br><span>           return;</span><br><span>      if (!lchan)</span><br><span>          return;</span><br><span>@@ -672,13 +672,12 @@</span><br><span> </span><br><span>  /* Log for both lchan FSM and conn FSM to ease reading the log in case of problems */</span><br><span>        if (detach_label) {</span><br><span style="color: hsl(0, 100%, 40%);">-             if (conn->fi)</span><br><span style="color: hsl(0, 100%, 40%);">-                        LOGPFSML(conn->fi, LOGL_DEBUG, "conn detaches lchan %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                          lchan->fi? osmo_fsm_inst_name(lchan->fi) : gsm_lchan_name(lchan));</span><br><span style="color: hsl(120, 100%, 40%);">+             LOGPFSML(conn->fi, LOGL_DEBUG, "conn detaches lchan %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                        lchan->fi? osmo_fsm_inst_name(lchan->fi) : gsm_lchan_name(lchan));</span><br><span> </span><br><span>                if (lchan->fi)</span><br><span>                    LOGPFSML(lchan->fi, LOGL_DEBUG, "conn %s detaches lchan (%s)\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                            conn->fi? osmo_fsm_inst_name(conn->fi) : "(conn without FSM)",</span><br><span style="color: hsl(120, 100%, 40%);">+                                osmo_fsm_inst_name(conn->fi) : "(conn without FSM)",</span><br><span>                            detach_label);</span><br><span>      }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11742">change 11742</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11742"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I62354aa998832131c86535f39a29294000114adc </div>
<div style="display:none"> Gerrit-Change-Number: 11742 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>