<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11713">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lchan_fsm_cleanup: drop redundant 'forget_lchan' call<br><br>Right below this call, we invoke lchan_reset(), and the first thing it does is<br>gscon_forget_lchan(). Drop this redundant invocation.<br><br>Change-Id: I503efceb6d34c8df0cdfef3dfc83fa1e61271c47<br>---<br>M src/osmo-bsc/lchan_fsm.c<br>1 file changed, 0 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index 915b62a..0046f59 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -1343,8 +1343,6 @@</span><br><span> void lchan_fsm_cleanup(struct osmo_fsm_inst *fi, enum osmo_fsm_term_cause cause)</span><br><span> {</span><br><span>      struct gsm_lchan *lchan = lchan_fi_lchan(fi);</span><br><span style="color: hsl(0, 100%, 40%);">-   if (lchan->conn)</span><br><span style="color: hsl(0, 100%, 40%);">-             gscon_forget_lchan(lchan->conn, lchan);</span><br><span>   lchan_reset(lchan);</span><br><span>  if (lchan->last_error) {</span><br><span>          talloc_free(lchan->last_error);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11713">change 11713</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11713"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I503efceb6d34c8df0cdfef3dfc83fa1e61271c47 </div>
<div style="display:none"> Gerrit-Change-Number: 11713 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>