<p><a href="https://gerrit.osmocom.org/11560">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/11560/4/src/gits">File src/gits:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/11560/4/src/gits@68">Patch Set #4, Line 68:</a> <code style="font-family:monospace,monospace">l:</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This seems to work - do you get the same output with your version? […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">my --porcelain --long seems to be identical to just status:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ▶ git status --porcelain --long<br> On branch neels/wip<br> Your branch and 'origin/neels/wip' have diverged,<br> and have 9 and 6 different commits each, respectively.<br> (use "git pull" to merge the remote branch into yours)</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> Untracked files:<br> (use "git add <file>..." to include in what will be committed)</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ../d.bsc/<br> ../m2/<br> ../make/<br> ../net/config_mine<br> ../net/config_sip<br> ../net/my_network/<br> ../net/nitb/<br> ../net/simcards.csv<br> ../net/sip/<br> ../net/tmpl_dyn/<br> ../openbsc/<br> ../quick_vty_tests.opts</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> nothing added to commit but untracked files present (use "git add" to track)</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/11560/4/src/gits@359">Patch Set #4, Line 359:</a> <code style="font-family:monospace,monospace">def cmd_fetch():</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">you don't need a shim for every git command, you can just put them in a list and iterate over them: […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Re: shim: the best for consistent help doc is to just add a shim.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Re argparse:<br>I see .. seems to me an awful lot of trouble for just sys.argv[1:].</p><p style="white-space: pre-wrap; word-wrap: break-word;">BTW, one thing I don't like about argparse is that it removes line feeds, i.e. paragraphs, from the doc string. In osmo_interact I did</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> parser = argparse.ArgumentParser(description=doc, formatter_class=argparse.RawDescriptionHelpFormatter)</pre><p style="white-space: pre-wrap; word-wrap: break-word;">but then you also need to take care of line feeds for option arg docs. All in all it often is more meh than yay to me.</p><p style="white-space: pre-wrap; word-wrap: break-word;">That said, if you want to change it to argparse so that it works and looks good, do go ahead in a follow-up patch. ok?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/11560/5/src/gits">File src/gits:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/11560/5/src/gits@6">Patch Set #5, Line 6:</a> <code style="font-family:monospace,monospace"># This program is free software: you can redistribute it and/or modify</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Out of curiosity: why not use the shorter SPDX form? […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">because I just copy-paste these things from elsewhere :P</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/11560">change 11560</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11560"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-dev </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I579e7af26d76d5c5d83b2349695456bc7b54f5a2 </div>
<div style="display:none"> Gerrit-Change-Number: 11560 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 07 Nov 2018 16:25:53 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>