<p>Max has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11636">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">NS: log address:port on error<br><br>Change-Id: If2dc533a6dc150254f5d44b672f04bb728e7e927<br>---<br>M src/gb/gprs_ns.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/36/11636/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c</span><br><span>index 198ead1..34bbfde 100644</span><br><span>--- a/src/gb/gprs_ns.c</span><br><span>+++ b/src/gb/gprs_ns.c</span><br><span>@@ -1510,6 +1510,8 @@</span><br><span>    struct msgb *msg = gprs_ns_msgb_alloc();</span><br><span>     int ret = 0;</span><br><span>         socklen_t saddr_len = sizeof(*saddr);</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t port, addr_len = 32;</span><br><span style="color: hsl(120, 100%, 40%);">+ char addr[addr_len];</span><br><span> </span><br><span>     if (!msg) {</span><br><span>          *error = -ENOMEM;</span><br><span>@@ -1519,8 +1521,9 @@</span><br><span>    ret = recvfrom(bfd->fd, msg->data, NS_ALLOC_SIZE - NS_ALLOC_HEADROOM, 0,</span><br><span>                       (struct sockaddr *)saddr, &saddr_len);</span><br><span>   if (ret < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-               LOGP(DNS, LOGL_ERROR, "recv error %s during NSIP recv\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                     strerror(errno));</span><br><span style="color: hsl(120, 100%, 40%);">+             osmo_sockaddr_to_str_and_uint(addr, addr_len, &port, (const struct sockaddr*)saddr);</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGP(DNS, LOGL_ERROR, "recv error %s during NSIP recvfrom %s:%u\n",</span><br><span style="color: hsl(120, 100%, 40%);">+              strerror(errno), addr, port);</span><br><span>           msgb_free(msg);</span><br><span>              *error = ret;</span><br><span>                return NULL;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11636">change 11636</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11636"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If2dc533a6dc150254f5d44b672f04bb728e7e927 </div>
<div style="display:none"> Gerrit-Change-Number: 11636 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>