<p>Max <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11556">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BSC LCLS: explicitly check for RSL_IE_CHAN_NR<br><br>Check that channel number IE is present in the received message. This<br>fixes following warning:<br><br>The value returned by function `@RSL_Types.f_rsl_find_ie' is not used<br><br>Change-Id: Icc6824d7acef809d76c70b5ff060a8261a82e2be<br>Related: OS#3659<br>---<br>M bsc/BSC_Tests_LCLS.ttcn<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests_LCLS.ttcn b/bsc/BSC_Tests_LCLS.ttcn</span><br><span>index 1c51995..0151329 100644</span><br><span>--- a/bsc/BSC_Tests_LCLS.ttcn</span><br><span>+++ b/bsc/BSC_Tests_LCLS.ttcn</span><br><span>@@ -605,8 +605,11 @@</span><br><span>    [] CONN_A.receive(tr_RSL_DEACT_SACCH(?));</span><br><span>    [] CONN_A.receive(tr_RSL_RF_CHAN_REL(?)) -> value rsl {</span><br><span>           var RSL_IE_Body ieb;</span><br><span style="color: hsl(0, 100%, 40%);">-            f_rsl_find_ie(rsl, RSL_IE_CHAN_NR, ieb);</span><br><span style="color: hsl(0, 100%, 40%);">-                CONN_A.send(ts_RSL_RF_CHAN_REL_ACK(ieb.chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+             if (f_rsl_find_ie(rsl, RSL_IE_CHAN_NR, ieb) == true) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        CONN_A.send(ts_RSL_RF_CHAN_REL_ACK(ieb.chan_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+             } else {</span><br><span style="color: hsl(120, 100%, 40%);">+                      log("Unable to find chan# in RSL_RF_CHAN_REL")</span><br><span style="color: hsl(120, 100%, 40%);">+              }</span><br><span>            }</span><br><span>    [] CONN_A.receive(tr_BSSMAP_ClearComplete) {</span><br><span>                 CONN_A.send(BSSAP_Conn_Prim:MSC_CONN_PRIM_DISC_REQ);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11556">change 11556</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11556"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Icc6824d7acef809d76c70b5ff060a8261a82e2be </div>
<div style="display:none"> Gerrit-Change-Number: 11556 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>