<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11578">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Neels Hofmeyr: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">hlr/HLR_EUSE.ttcn: remove redundant code from f_main_mo()<br><br>There is no need to pass session state from f_main_mo() to a<br>choosen EUSE handler (e.g. f_ss_echo), because a handler<br>itself is capable to extract the session state IE.<br><br>Change-Id: I1054baf3e7dafd05b797610b586e6202740f07b6<br>---<br>M hlr/HLR_EUSE.ttcn<br>1 file changed, 9 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/hlr/HLR_EUSE.ttcn b/hlr/HLR_EUSE.ttcn</span><br><span>index 1e7574b..93eb8f4 100644</span><br><span>--- a/hlr/HLR_EUSE.ttcn</span><br><span>+++ b/hlr/HLR_EUSE.ttcn</span><br><span>@@ -50,14 +50,17 @@</span><br><span>  }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-type function f_euse_cb(GSUP_SessionState ss_state, GSUP_PDU rx_pdu) return GSUP_PDU;</span><br><span style="color: hsl(120, 100%, 40%);">+type function f_euse_cb(GSUP_PDU rx_pdu) return GSUP_PDU;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-function f_ss_echo_continue(GSUP_SessionState ss_state, GSUP_PDU rx_pdu) return GSUP_PDU {</span><br><span style="color: hsl(120, 100%, 40%);">+function f_ss_echo_continue(GSUP_PDU rx_pdu) return GSUP_PDU {</span><br><span>     var GSUP_SessionState ss_next_state;</span><br><span style="color: hsl(0, 100%, 40%);">-    var GSUP_IeValue ss_ie;</span><br><span style="color: hsl(120, 100%, 40%);">+       var GSUP_IeValue ss_ie, state_ie;</span><br><span>    var SS_FacilityInformation dec_fac, rsp_fac;</span><br><span>         var octetstring ss_rsp;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   f_gsup_find_ie(rx_pdu, OSMO_GSUP_SS_INFO_IE, state_ie);</span><br><span style="color: hsl(120, 100%, 40%);">+       var GSUP_SessionState ss_state := state_ie.session_state;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  f_gsup_find_ie(rx_pdu, OSMO_GSUP_SS_INFO_IE, ss_ie);</span><br><span>         dec_fac := dec_SS_FacilityInformation(ss_ie.ss_info);</span><br><span>        log("dec_fac: ", dec_fac);</span><br><span>@@ -74,7 +77,7 @@</span><br><span>                                        ss_next_state, ss_rsp));</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-function f_ss_echo(GSUP_SessionState ss_state, GSUP_PDU rx_pdu) return GSUP_PDU {</span><br><span style="color: hsl(120, 100%, 40%);">+function f_ss_echo(GSUP_PDU rx_pdu) return GSUP_PDU {</span><br><span>         var GSUP_IeValue ss_ie;</span><br><span>      var SS_FacilityInformation dec_fac, rsp_fac;</span><br><span>         var octetstring ss_rsp;</span><br><span>@@ -100,15 +103,8 @@</span><br><span> </span><br><span>   while (true) {</span><br><span>               alt {</span><br><span style="color: hsl(0, 100%, 40%);">-           [] EUSE.receive(tr_GSUP_PROC_SS_REQ(?, ?, OSMO_GSUP_SESSION_STATE_BEGIN)) -> value rx_pdu {</span><br><span style="color: hsl(0, 100%, 40%);">-                  EUSE.send(cb_fn.apply(OSMO_GSUP_SESSION_STATE_BEGIN, rx_pdu));</span><br><span style="color: hsl(0, 100%, 40%);">-                  }</span><br><span style="color: hsl(0, 100%, 40%);">-               [] EUSE.receive(tr_GSUP_PROC_SS_REQ(?, ?, OSMO_GSUP_SESSION_STATE_CONTINUE)) -> value rx_pdu {</span><br><span style="color: hsl(0, 100%, 40%);">-                       EUSE.send(cb_fn.apply(OSMO_GSUP_SESSION_STATE_CONTINUE, rx_pdu));</span><br><span style="color: hsl(0, 100%, 40%);">-                       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-               [] EUSE.receive(tr_GSUP_PROC_SS_REQ(?, ?, OSMO_GSUP_SESSION_STATE_END)) -> value rx_pdu {</span><br><span style="color: hsl(0, 100%, 40%);">-                    EUSE.send(cb_fn.apply(OSMO_GSUP_SESSION_STATE_END, rx_pdu));</span><br><span style="color: hsl(120, 100%, 40%);">+          [] EUSE.receive(tr_GSUP_PROC_SS_REQ(?, ?, ?)) -> value rx_pdu {</span><br><span style="color: hsl(120, 100%, 40%);">+                    EUSE.send(cb_fn.apply(rx_pdu));</span><br><span>                      }</span><br><span> </span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11578">change 11578</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11578"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I1054baf3e7dafd05b797610b586e6202740f07b6 </div>
<div style="display:none"> Gerrit-Change-Number: 11578 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>