<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11576">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Update cipher reject function<br><br>* add note about (yet) unsupported standard feature<br>* use enum constant instead of hex value<br><br>Change-Id: I5cc5fc1ae8d5474dbc8d3385a493adf6420a3c98<br>Related: OS#3187<br>---<br>M src/gsm/gsm0808.c<br>M tests/gsm0808/gsm0808_test.c<br>2 files changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c</span><br><span>index 9ccca4d..e5c3e30 100644</span><br><span>--- a/src/gsm/gsm0808.c</span><br><span>+++ b/src/gsm/gsm0808.c</span><br><span>@@ -275,6 +275,7 @@</span><br><span>          return NULL;</span><br><span> </span><br><span>     msgb_v_put(msg, BSS_MAP_MSG_CIPHER_MODE_REJECT);</span><br><span style="color: hsl(120, 100%, 40%);">+      /* FIXME: support 2-byte cause value as per 3GPP TS 08.08 §3.2.2.5 */</span><br><span>       msgb_tlv_put(msg, GSM0808_IE_CAUSE, 1, &cause);</span><br><span> </span><br><span>      msg->l3h = msgb_tv_push(msg, BSSAP_MSG_BSS_MANAGEMENT, msgb_length(msg));</span><br><span>diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c</span><br><span>index 0b2794f..7111db9 100644</span><br><span>--- a/tests/gsm0808/gsm0808_test.c</span><br><span>+++ b/tests/gsm0808/gsm0808_test.c</span><br><span>@@ -248,7 +248,7 @@</span><br><span>      struct msgb *msg;</span><br><span> </span><br><span>        printf("Testing creating Cipher Reject\n");</span><br><span style="color: hsl(0, 100%, 40%);">-   msg = gsm0808_create_cipher_reject(0x23);</span><br><span style="color: hsl(120, 100%, 40%);">+     msg = gsm0808_create_cipher_reject(GSM0808_CAUSE_CCCH_OVERLOAD);</span><br><span>     VERIFY(msg, res, ARRAY_SIZE(res));</span><br><span>   msgb_free(msg);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11576">change 11576</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11576"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I5cc5fc1ae8d5474dbc8d3385a493adf6420a3c98 </div>
<div style="display:none"> Gerrit-Change-Number: 11576 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>