<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11538">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP<br><br>Fixes: coverity scan CID#189459<br>Change-Id: Ib9c5e374b9c5c8f79eecf95c439a25b0f438e4e5<br>---<br>M src/osmo-bsc/bts_ipaccess_nanobts.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/11538/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c</span><br><span>index 40cabb8..1fffd89 100644</span><br><span>--- a/src/osmo-bsc/bts_ipaccess_nanobts.c</span><br><span>+++ b/src/osmo-bsc/bts_ipaccess_nanobts.c</span><br><span>@@ -32,6 +32,7 @@</span><br><span> #include <osmocom/core/msgb.h></span><br><span> #include <osmocom/core/socket.h></span><br><span> #include <osmocom/core/talloc.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/utils.h></span><br><span> #include <osmocom/bsc/gsm_data.h></span><br><span> #include <osmocom/bsc/abis_nm.h></span><br><span> #include <osmocom/bsc/abis_rsl.h></span><br><span>@@ -494,7 +495,7 @@</span><br><span>                         return;</span><br><span>              entry->site_id = site_id;</span><br><span>                 entry->bts_id = bts_id;</span><br><span style="color: hsl(0, 100%, 40%);">-              strncpy(entry->ip, ip, sizeof(entry->ip));</span><br><span style="color: hsl(120, 100%, 40%);">+              osmo_strlcpy(entry->ip, ip, sizeof(entry->ip));</span><br><span>        }</span><br><span> </span><br><span>        /* Add to beginning with current timestamp */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11538">change 11538</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11538"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib9c5e374b9c5c8f79eecf95c439a25b0f438e4e5 </div>
<div style="display:none"> Gerrit-Change-Number: 11538 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>