<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11489">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/VTY: fix CONFIG prompt matching in f_vty_wait_for_prompt()<br><br>Matching the CONFIG prompt using implicit '\w+(*)' pattern is<br>a bad idea, because it can actually match almost anything:<br><br>  - 'OsmoBlaBla(config)# ',<br>  - 'OsmoBlaBla(config) ',<br>  - 'OsmoBlaBla> ',<br>  - 'Mahlzeit'!<br><br>One problem is that the parentheses are interpreted as a matching<br>operator (which is used to group an expression), so they should<br>have been escaped by '\'. Another problem is that this pattern<br>is not complete, because '\# ' is missing. Let's fix this!<br><br>Change-Id: I8a0e3fcfb0c4e5854b7b1e39296052e679c63c73<br>Related: OS#3675<br>---<br>M library/Osmocom_VTY_Functions.ttcn<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/Osmocom_VTY_Functions.ttcn b/library/Osmocom_VTY_Functions.ttcn</span><br><span>index b822645..86f58f1 100644</span><br><span>--- a/library/Osmocom_VTY_Functions.ttcn</span><br><span>+++ b/library/Osmocom_VTY_Functions.ttcn</span><br><span>@@ -53,7 +53,7 @@</span><br><span>              alt {</span><br><span>                        [] pt.receive(pattern "\w+" & VTY_VIEW_SUFFIX) { };</span><br><span>                    [] pt.receive(pattern "\w+\# ") { };</span><br><span style="color: hsl(0, 100%, 40%);">-                  [] pt.receive(pattern "\w+" & VTY_CFG_SUFFIX) { };</span><br><span style="color: hsl(120, 100%, 40%);">+                      [] pt.receive(pattern "\w+\(*\)\# ") { };</span><br><span>                  [] pt.receive(t_vty_unknown) {</span><br><span>                               testcase.stop(fail, "VTY: Unknown Command");</span><br><span>                               };</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11489">change 11489</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11489"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I8a0e3fcfb0c4e5854b7b1e39296052e679c63c73 </div>
<div style="display:none"> Gerrit-Change-Number: 11489 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>