<p>Pau Espin Pedrol <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11428">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts: Disable testing FACCH/H with real HW<br><br>Temporary disable testing on FACCH/H because Calypso PHY is not stable.<br>Otherwise some tests fail half of the time due to this unstability.<br><br>Related: OS#3653<br>Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 22 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index a2d4ca4..fe0a933 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -313,17 +313,29 @@</span><br><span>              valueof(ts_RslChanNr_SDCCH8(6,4)), valueof(ts_RslChanNr_SDCCH8(6,5)),</span><br><span>                valueof(ts_RslChanNr_SDCCH8(6,6)), valueof(ts_RslChanNr_SDCCH8(6,7))</span><br><span>         };</span><br><span style="color: hsl(0, 100%, 40%);">-      g_AllChanTypes := {</span><br><span style="color: hsl(0, 100%, 40%);">-             /* TS 1..4: TCH/F */</span><br><span style="color: hsl(0, 100%, 40%);">-            valueof(ts_RslChanNr_Bm(1)),</span><br><span style="color: hsl(0, 100%, 40%);">-            /* TS 5: TCH/H */</span><br><span style="color: hsl(0, 100%, 40%);">-               valueof(ts_RslChanNr_Lm(5,1)),</span><br><span style="color: hsl(0, 100%, 40%);">-          /* TS 0: SDCCH/4 */</span><br><span style="color: hsl(0, 100%, 40%);">-             valueof(ts_RslChanNr_SDCCH4(0,2)),</span><br><span style="color: hsl(0, 100%, 40%);">-              /* TS 6: SDCCH/8 */</span><br><span style="color: hsl(0, 100%, 40%);">-             valueof(ts_RslChanNr_SDCCH8(6,4))</span><br><span style="color: hsl(0, 100%, 40%);">-       };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        /* FIXME: FACCH/H is unreliable with calypso firmware, see OS#3653 */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (mp_bb_trxc_port != -1) {</span><br><span style="color: hsl(120, 100%, 40%);">+          g_AllChanTypes := {</span><br><span style="color: hsl(120, 100%, 40%);">+                   /* TS 1..4: TCH/F */</span><br><span style="color: hsl(120, 100%, 40%);">+                  valueof(ts_RslChanNr_Bm(1)),</span><br><span style="color: hsl(120, 100%, 40%);">+                  /* TS 5: TCH/H */</span><br><span style="color: hsl(120, 100%, 40%);">+                     valueof(ts_RslChanNr_Lm(5,1)),</span><br><span style="color: hsl(120, 100%, 40%);">+                        /* TS 0: SDCCH/4 */</span><br><span style="color: hsl(120, 100%, 40%);">+                   valueof(ts_RslChanNr_SDCCH4(0,2)),</span><br><span style="color: hsl(120, 100%, 40%);">+                    /* TS 6: SDCCH/8 */</span><br><span style="color: hsl(120, 100%, 40%);">+                   valueof(ts_RslChanNr_SDCCH8(6,4))</span><br><span style="color: hsl(120, 100%, 40%);">+             };</span><br><span style="color: hsl(120, 100%, 40%);">+    } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              g_AllChanTypes := {</span><br><span style="color: hsl(120, 100%, 40%);">+                   /* TS 1..4: TCH/F */</span><br><span style="color: hsl(120, 100%, 40%);">+                  valueof(ts_RslChanNr_Bm(1)),</span><br><span style="color: hsl(120, 100%, 40%);">+                  /* TS 0: SDCCH/4 */</span><br><span style="color: hsl(120, 100%, 40%);">+                   valueof(ts_RslChanNr_SDCCH4(0,2)),</span><br><span style="color: hsl(120, 100%, 40%);">+                    /* TS 6: SDCCH/8 */</span><br><span style="color: hsl(120, 100%, 40%);">+                   valueof(ts_RslChanNr_SDCCH8(6,4))</span><br><span style="color: hsl(120, 100%, 40%);">+             };</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span>    f_init_rsl(id);</span><br><span>      T.start;</span><br><span>     alt {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11428">change 11428</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11428"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d </div>
<div style="display:none"> Gerrit-Change-Number: 11428 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>