<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11425">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_pchan2chan_nr: Fix conversion of CCCH_LCHAN<br><br>Previous implementation made no sense, since chan_nr is never read<br>before being set below from lchan_nr.<br><br>Furthemore, if lcahn_nr=CCH_LCHAN=4, then:<br>cbits = 0x4 + lchan_nr = 0x8 = b1000 which then becomes SDCCH8 according<br>to GSM 08.58 9.3.1, so it's totally wrong:<br>SDCCH/8 + ACCH     0 1 T T T<br><br>Change-Id: Id1dee716991e6faa406f02c029e998af5780162a<br>---<br>M src/common/gsm_data_shared.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/gsm_data_shared.c b/src/common/gsm_data_shared.c</span><br><span>index 2a1f9c8..8c3229c 100644</span><br><span>--- a/src/common/gsm_data_shared.c</span><br><span>+++ b/src/common/gsm_data_shared.c</span><br><span>@@ -622,7 +622,7 @@</span><br><span>            * See osmo-bts-xxx/oml.c:opstart_compl().</span><br><span>            */</span><br><span>          if (lchan_nr == CCCH_LCHAN)</span><br><span style="color: hsl(0, 100%, 40%);">-                     chan_nr = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+                  lchan_nr = 0;</span><br><span>                else</span><br><span>                         OSMO_ASSERT(lchan_nr < 4);</span><br><span>                cbits = 0x04;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11425">change 11425</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11425"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Id1dee716991e6faa406f02c029e998af5780162a </div>
<div style="display:none"> Gerrit-Change-Number: 11425 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>