<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11421">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipaccess-config: Fix open() return value checking<br><br>open() returning 0 is valid, but negative values indicate errors.<br><br>Change-Id: Id7e62116bfee550ef9906e78a0fce6f28af27a97<br>Fixes: Coverity CID#57865<br>---<br>M src/ipaccess/ipaccess-config.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/21/11421/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c</span><br><span>index 079bae2..5491700 100644</span><br><span>--- a/src/ipaccess/ipaccess-config.c</span><br><span>+++ b/src/ipaccess/ipaccess-config.c</span><br><span>@@ -634,7 +634,7 @@</span><br><span>      INIT_LLIST_HEAD(entry);</span><br><span> </span><br><span>  fd = open(filename, O_RDONLY);</span><br><span style="color: hsl(0, 100%, 40%);">-  if (!fd) {</span><br><span style="color: hsl(120, 100%, 40%);">+    if (fd < 0) {</span><br><span>             perror("nada");</span><br><span>            return -1;</span><br><span>   }</span><br><span>@@ -729,7 +729,7 @@</span><br><span> </span><br><span>  printf("Opening possible firmware '%s'\n", filename);</span><br><span>      fd = open(filename, O_RDONLY);</span><br><span style="color: hsl(0, 100%, 40%);">-  if (!fd) {</span><br><span style="color: hsl(120, 100%, 40%);">+    if (fd < 0) {</span><br><span>             perror("nada");</span><br><span>            return;</span><br><span>      }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11421">change 11421</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11421"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id7e62116bfee550ef9906e78a0fce6f28af27a97 </div>
<div style="display:none"> Gerrit-Change-Number: 11421 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>