<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11409">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">subscr_conn_fsm: Fix null-pointer deref / N-CONNECT.ind from unknown MSC<br><br>Change-Id: Id0eca3dd729d2e4c8c6ff83f05efde00b42c16f1<br>Fixes: Coverity CID#188860<br>---<br>M src/osmo-bsc/bsc_subscr_conn_fsm.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/09/11409/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>index 52afd54..bca9e1f 100644</span><br><span>--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>@@ -276,8 +276,9 @@</span><br><span>               if (!conn->sccp.msc) {</span><br><span>                    LOGPFSML(fi, LOGL_NOTICE, "N-CONNECT.ind from unknown MSC %s\n",</span><br><span>                            osmo_sccp_addr_dump(&scu_prim->u.connect.calling_addr));</span><br><span style="color: hsl(0, 100%, 40%);">-                        osmo_sccp_tx_disconn(conn->sccp.msc->a.sccp_user, scu_prim->u.connect.conn_id,</span><br><span style="color: hsl(0, 100%, 40%);">-                                      &scu_prim->u.connect.called_addr, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+                     /* We cannot find a way to the sccp_user without the MSC, so we cannot</span><br><span style="color: hsl(120, 100%, 40%);">+                         * use osmo_sccp_tx_disconn() :( */</span><br><span style="color: hsl(120, 100%, 40%);">+                   //osmo_sccp_tx_disconn(conn->sccp.msc->a.sccp_user, scu_prim->u.connect.conn_id, &scu_prim->u.connect.called_addr, 0);</span><br><span>                       osmo_fsm_inst_term(fi, OSMO_FSM_TERM_REGULAR, NULL);</span><br><span>                         return;</span><br><span>              }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11409">change 11409</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11409"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id0eca3dd729d2e4c8c6ff83f05efde00b42c16f1 </div>
<div style="display:none"> Gerrit-Change-Number: 11409 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>