<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11406">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx_validate_config(): Fix validation of rx_sps<br><br>Change-Id: I7e932cff59335add09c76caba6f9ac1e7cf69022<br>Fixes: Coverity CID#188871<br>---<br>M Transceiver52M/osmo-trx.cpp<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp</span><br><span>index d01a4cf..7f72c47 100644</span><br><span>--- a/Transceiver52M/osmo-trx.cpp</span><br><span>+++ b/Transceiver52M/osmo-trx.cpp</span><br><span>@@ -376,7 +376,7 @@</span><br><span> </span><br><span>   /* Force 4 SPS for EDGE or multi-ARFCN configurations */</span><br><span>     if ((trx->cfg.egprs || trx->cfg.multi_arfcn) &&</span><br><span style="color: hsl(0, 100%, 40%);">-       (trx->cfg.tx_sps!=4 || trx->cfg.tx_sps!=4)) {</span><br><span style="color: hsl(120, 100%, 40%);">+           (trx->cfg.tx_sps!=4 || trx->cfg.rx_sps!=4)) {</span><br><span>              LOG(ERROR) << "EDGE and Multi-Carrier options require 4 tx and rx sps. Check you config.";</span><br><span>           return -1;</span><br><span>   }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11406">change 11406</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11406"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I7e932cff59335add09c76caba6f9ac1e7cf69022 </div>
<div style="display:none"> Gerrit-Change-Number: 11406 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Assignee: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-CC: Pau Espin Pedrol <pespin@sysmocom.de> </div>