<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11408">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">acc_ramp: An unsigned int is always >= 0<br><br>Change-Id: I653ae9ede578370b4d7b1a150e9ec3c0702bbb31<br>Fixes: Coverity CID#188862<br>---<br>M src/osmo-bsc/acc_ramp.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/acc_ramp.c b/src/osmo-bsc/acc_ramp.c</span><br><span>index ac9f02d..bc2e3fb 100644</span><br><span>--- a/src/osmo-bsc/acc_ramp.c</span><br><span>+++ b/src/osmo-bsc/acc_ramp.c</span><br><span>@@ -36,7 +36,7 @@</span><br><span>  */</span><br><span> static bool acc_is_permanently_barred(struct gsm_bts *bts, unsigned int acc)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-      OSMO_ASSERT(acc >= 0 && acc <= 9);</span><br><span style="color: hsl(120, 100%, 40%);">+      OSMO_ASSERT(acc <= 9);</span><br><span>    if (acc == 8 || acc == 9)</span><br><span>            return (bts->si_common.rach_control.t2 & (1 << (acc - 8)));</span><br><span>     return (bts->si_common.rach_control.t3 & (1 << (acc)));</span><br><span>@@ -44,7 +44,7 @@</span><br><span> </span><br><span> static void allow_one_acc(struct acc_ramp *acc_ramp, unsigned int acc)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-     OSMO_ASSERT(acc >= 0 && acc <= 9);</span><br><span style="color: hsl(120, 100%, 40%);">+      OSMO_ASSERT(acc <= 9);</span><br><span>    if (acc_ramp->barred_accs & (1 << acc))</span><br><span>                 LOGP(DRSL, LOGL_NOTICE, "(bts=%d) ACC RAMP: allowing Access Control Class %u\n", acc_ramp->bts->nr, acc);</span><br><span>    acc_ramp->barred_accs &= ~(1 << acc);</span><br><span>@@ -52,7 +52,7 @@</span><br><span> </span><br><span> static void barr_one_acc(struct acc_ramp *acc_ramp, unsigned int acc)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-        OSMO_ASSERT(acc >= 0 && acc <= 9);</span><br><span style="color: hsl(120, 100%, 40%);">+      OSMO_ASSERT(acc <= 9);</span><br><span>    if ((acc_ramp->barred_accs & (1 << acc)) == 0)</span><br><span>          LOGP(DRSL, LOGL_NOTICE, "(bts=%d) ACC RAMP: barring Access Control Class %u\n", acc_ramp->bts->nr, acc);</span><br><span>     acc_ramp->barred_accs |= (1 << acc);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11408">change 11408</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11408"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I653ae9ede578370b4d7b1a150e9ec3c0702bbb31 </div>
<div style="display:none"> Gerrit-Change-Number: 11408 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>