<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11413">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">timerfd_create(): Fix error handling of osmo_fd_register()<br><br>Change-Id: Ia2528cc3e3155bbc9cb32dee0e3af99cc6e1c654<br>Closes: Coverity CID#188853<br>---<br>M src/select.c<br>1 file changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/13/11413/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/select.c b/src/select.c</span><br><span>index 0b115c6..b07ad8c 100644</span><br><span>--- a/src/select.c</span><br><span>+++ b/src/select.c</span><br><span>@@ -324,11 +324,17 @@</span><br><span>      ofd->when = BSC_FD_READ;</span><br><span> </span><br><span>      if (ofd->fd < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+              int rc;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>            ofd->fd = timerfd_create(CLOCK_MONOTONIC, TFD_NONBLOCK);</span><br><span>          if (ofd->fd < 0)</span><br><span>                       return ofd->fd;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-          osmo_fd_register(ofd);</span><br><span style="color: hsl(120, 100%, 40%);">+                rc = osmo_fd_register(ofd);</span><br><span style="color: hsl(120, 100%, 40%);">+           if (rc < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                      close(ofd->fd);</span><br><span style="color: hsl(120, 100%, 40%);">+                    return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+            }</span><br><span>    }</span><br><span>    return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11413">change 11413</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11413"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia2528cc3e3155bbc9cb32dee0e3af99cc6e1c654 </div>
<div style="display:none"> Gerrit-Change-Number: 11413 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>