<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11396">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-config-merge: fclose() what we fopen()<br><br>Change-Id: Ib44f902e5bca2277f1b340d34fabbd2a298d683e<br>Fixes: Coverity CID#188851<br>---<br>M utils/osmo-config-merge.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/utils/osmo-config-merge.c b/utils/osmo-config-merge.c</span><br><span>index a872d64..afaf86b 100644</span><br><span>--- a/utils/osmo-config-merge.c</span><br><span>+++ b/utils/osmo-config-merge.c</span><br><span>@@ -144,6 +144,7 @@</span><br><span>                   if (indent > cur_indent+1) {</span><br><span>                              fprintf(stderr, "File '%s' isn't well-formed in line %u, aborting!\n",</span><br><span>                                         fname, line_num);</span><br><span style="color: hsl(120, 100%, 40%);">+                             fclose(infile);</span><br><span>                              return NULL;</span><br><span>                         }</span><br><span>                    /* new child to last node */</span><br><span>@@ -166,6 +167,7 @@</span><br><span>           cur_indent = indent;</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ fclose(infile);</span><br><span>      return root;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11396">change 11396</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11396"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ib44f902e5bca2277f1b340d34fabbd2a298d683e </div>
<div style="display:none"> Gerrit-Change-Number: 11396 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>