<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11407">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipaccess-proxy: Add error handling to IAP CCM ID RESP parsing<br><br>Change-Id: I56ec149979572486b904fc1409cf3cd096b6eb34<br>Fixes: Coverity CID#188867<br>---<br>M src/ipaccess/ipaccess-proxy.c<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/11407/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ipaccess/ipaccess-proxy.c b/src/ipaccess/ipaccess-proxy.c</span><br><span>index a2ce633..26c5bcd 100644</span><br><span>--- a/src/ipaccess/ipaccess-proxy.c</span><br><span>+++ b/src/ipaccess/ipaccess-proxy.c</span><br><span>@@ -458,7 +458,11 @@</span><br><span>   case IPAC_MSGT_ID_RESP:</span><br><span>              DEBUGP(DLMI, "ID_RESP ");</span><br><span>          /* parse tags, search for Unit ID */</span><br><span style="color: hsl(0, 100%, 40%);">-            ipa_ccm_id_resp_parse(&tlvp, (uint8_t *)msg->l2h+1, msgb_l2len(msg)-1);</span><br><span style="color: hsl(120, 100%, 40%);">+                ret = ipa_ccm_id_resp_parse(&tlvp, (uint8_t *)msg->l2h+1, msgb_l2len(msg)-1);</span><br><span style="color: hsl(120, 100%, 40%);">+          if (ret < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                     LOGP(DLINP, LOGL_ERROR, "Error parsing CCM ID RESP !?!\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                 return -EIO;</span><br><span style="color: hsl(120, 100%, 40%);">+          }</span><br><span>            DEBUGP(DLMI, "\n");</span><br><span> </span><br><span>            if (!TLVP_PRESENT(&tlvp, IPAC_IDTAG_UNIT)) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11407">change 11407</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11407"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I56ec149979572486b904fc1409cf3cd096b6eb34 </div>
<div style="display:none"> Gerrit-Change-Number: 11407 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>