<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11401">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_rlcmac_received_lost(): Fix regression / uninitialized now_tv<br><br>In Change-Id I7d22e7b5902c230efeae66eb20c17026a4037887 we<br>introduced the use of timespecsub(). Unfortuantely, we also<br>accidentially removed the call to osmo_clock_gettime() along<br>with it, leaving now_tv completely uninitialized.<br><br>Change-Id: Ieced0c62700b2fe4ab0208258183154cc701490b<br>Related: OS#3225<br>Fixes: Coverity CID#188872<br>---<br>M src/gprs_rlcmac_meas.cpp<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_rlcmac_meas.cpp b/src/gprs_rlcmac_meas.cpp</span><br><span>index f6448d5..9ff06db 100644</span><br><span>--- a/src/gprs_rlcmac_meas.cpp</span><br><span>+++ b/src/gprs_rlcmac_meas.cpp</span><br><span>@@ -131,6 +131,7 @@</span><br><span>     tbf->m_bw.dl_loss_received += received;</span><br><span>   tbf->m_bw.dl_loss_lost += lost;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        osmo_clock_gettime(CLOCK_MONOTONIC, &now_tv);</span><br><span>    timespecsub(&now_tv, loss_tv, &elapsed);</span><br><span>     if (elapsed.tv_sec < 1)</span><br><span>           return 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11401">change 11401</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11401"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ieced0c62700b2fe4ab0208258183154cc701490b </div>
<div style="display:none"> Gerrit-Change-Number: 11401 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Assignee: Stefan Sperling <ssperling@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-CC: Stefan Sperling <ssperling@sysmocom.de> </div>