<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11416">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">telnet_interface: avoid double-close of fd()<br><br>Change-Id: Ibd81f29fa22d53553bd73c055d6a1f5255a69bad<br>Fixes: Coverity CID#135238<br>---<br>M src/vty/telnet_interface.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/16/11416/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/telnet_interface.c b/src/vty/telnet_interface.c</span><br><span>index 0ccf8dc..fdd88c1 100644</span><br><span>--- a/src/vty/telnet_interface.c</span><br><span>+++ b/src/vty/telnet_interface.c</span><br><span>@@ -177,7 +177,7 @@</span><br><span>  connection->vty = vty_create(new_connection, connection);</span><br><span>         if (!connection->vty) {</span><br><span>           LOGP(0, LOGL_ERROR, "couldn't create VTY\n");</span><br><span style="color: hsl(0, 100%, 40%);">-             close(new_connection);</span><br><span style="color: hsl(120, 100%, 40%);">+                /* vty_create() is already closing the fd if it returns NULL */</span><br><span>              talloc_free(connection);</span><br><span>             return -1;</span><br><span>   }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11416">change 11416</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11416"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ibd81f29fa22d53553bd73c055d6a1f5255a69bad </div>
<div style="display:none"> Gerrit-Change-Number: 11416 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>