<p>Patch set 5:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/9204">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/9204/5/library/BSSMAP_Emulation.ttcn">File library/BSSMAP_Emulation.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9204/5/library/BSSMAP_Emulation.ttcn@51">Patch Set #5, Line 51:</a> <code style="font-family:monospace,monospace">      </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">(ws)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9204/5/library/BSSMAP_Emulation.ttcn@54">Patch Set #5, Line 54:</a> <code style="font-family:monospace,monospace">    port BSSMAPEM_PROC_PT BSSAP_PROC_1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think with BTS we have an array of them? Is that possible with component ports? (arrays potentially save the need to code dup for each instance)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/9204/5/msc/BSC_ConnectionHandler.ttcn">File msc/BSC_ConnectionHandler.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9204/5/msc/BSC_ConnectionHandler.ttcn@53">Patch Set #5, Line 53:</a> <code style="font-family:monospace,monospace">type record of BSC_ConnHdlrBscPars BSC_ConnHdlrBscParsTable;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ah, there's an array of BSCs here</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/9204">change 9204</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9204"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib3eabf8537066f43faed8fb983d9e1f4092ec515 </div>
<div style="display:none"> Gerrit-Change-Number: 9204 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 17 Oct 2018 14:17:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>