<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11356">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">add chopped IPA ping test to BTS tests<br><br>Run the chopped IPA ping test from the IPA_Testing module<br>as part of the BTS test suite. Contrary to the BSC version<br>of this test, this test listens for an IPA connection rather<br>than connecting to an IPA server. Make code in the IPA_Testing<br>module for accepting connections actually work.<br><br>Change-Id: I4804ccabd342b82d44e69dbc6eaaae220ec7d4e4<br>Related: OS#2010<br>---<br>M bts/BTS_Tests.ttcn<br>M bts/gen_links.sh<br>M library/IPA_Testing.ttcn<br>3 files changed, 12 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 82a54f3..2d59627 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -15,6 +15,7 @@</span><br><span> import from RSL_Types all;</span><br><span> import from IPA_Types all;</span><br><span> import from IPA_Emulation all;</span><br><span style="color: hsl(120, 100%, 40%);">+import from IPA_Testing all;</span><br><span> import from RSL_Emulation all;</span><br><span> </span><br><span> import from IPL4asp_Types all;</span><br><span>@@ -4146,6 +4147,10 @@</span><br><span> f_tch_sign_l2_fill_frame(true);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_chopped_ipa_ping() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ IPA_Testing.f_run_TC_chopped_ipa_ping(mp_rsl_ip, mp_rsl_port, LISTEN_FOR_CLIENT);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* test generation of RLL ERR IND based on Um errors (TS 48.058 3.9) */</span><br><span> /* protocol error as per 44.006 */</span><br><span> /* link layer failure (repetition of I-frame N200 times without ACK */</span><br><span>@@ -4278,6 +4283,8 @@</span><br><span> </span><br><span> execute( TC_tch_sign_l2_fill_frame() );</span><br><span> execute( TC_tch_sign_l2_fill_frame_dtxd() );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_chopped_ipa_ping() );</span><br><span> }</span><br><span> </span><br><span> </span><br><span>diff --git a/bts/gen_links.sh b/bts/gen_links.sh</span><br><span>index b6c4e12..1ec6153 100755</span><br><span>--- a/bts/gen_links.sh</span><br><span>+++ b/bts/gen_links.sh</span><br><span>@@ -42,6 +42,7 @@</span><br><span> FILES+="Native_Functions.ttcn Native_FunctionDefs.cc "</span><br><span> FILES+="TRXC_Types.ttcn TRXC_CodecPort.ttcn TRXC_CodecPort_CtrlFunct.ttcn TRXC_CodecPort_CtrlFunctDef.cc "</span><br><span> FILES+="PCUIF_Types.ttcn PCUIF_CodecPort.ttcn "</span><br><span style="color: hsl(120, 100%, 40%);">+FILES+="IPA_Testing.ttcn"</span><br><span> gen_links $DIR $FILES</span><br><span> </span><br><span> ignore_pp_results</span><br><span>diff --git a/library/IPA_Testing.ttcn b/library/IPA_Testing.ttcn</span><br><span>index 62aa143..a94dd46 100644</span><br><span>--- a/library/IPA_Testing.ttcn</span><br><span>+++ b/library/IPA_Testing.ttcn</span><br><span>@@ -139,8 +139,10 @@</span><br><span> if (conmode == CONNECT_TO_SERVER) {</span><br><span> f_send_chopped_ipa_msg(ipa_ip, ipa_tcp_port, connId, ipa_msg_ping);</span><br><span> } else {</span><br><span style="color: hsl(0, 100%, 40%);">- IPL4.receive(t_recvfrom(omit)) -> value asp_rx {</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_chopped_ipa_msg(asp_rx.remName, asp_rx.remPort, connId, ipa_msg_ping);</span><br><span style="color: hsl(120, 100%, 40%);">+ var PortEvent port_evt;</span><br><span style="color: hsl(120, 100%, 40%);">+ IPL4.receive(PortEvent:{connOpened := ?}) -> value port_evt {</span><br><span style="color: hsl(120, 100%, 40%);">+ var ConnectionOpenedEvent conn := port_evt.connOpened;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_chopped_ipa_msg(conn.remName, conn.remPort, conn.connId, ipa_msg_ping);</span><br><span> }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11356">change 11356</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11356"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I4804ccabd342b82d44e69dbc6eaaae220ec7d4e4 </div>
<div style="display:none"> Gerrit-Change-Number: 11356 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>