<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11363">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">remsim: fix TPDU response size transmission<br><br>the TDPU response data size can be up to 256.<br>this length cannot be stored in a uint8_t, which would cause the<br>length to become 0, no data being send, and the reader reset the<br>card because of misbehaviour of the card (i.e. no/malformed<br>response leading to the timeout of the waiting time).<br><br>Change-Id: Id38f9e597ffff242e89ea3dd9fbdf0c9f444cc03<br>---<br>M src/simtrace2-remsim_client.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/simtrace2-remsim_client.c b/src/simtrace2-remsim_client.c</span><br><span>index f54ace3..365acb4 100644</span><br><span>--- a/src/simtrace2-remsim_client.c</span><br><span>+++ b/src/simtrace2-remsim_client.c</span><br><span>@@ -201,7 +201,7 @@</span><br><span> </span><br><span> /*! \brief Request the SIMtrace2 to transmit a Procedure Byte, then Tx */</span><br><span> static int cardem_request_pb_and_tx(struct cardem_inst *ci, uint8_t pb,</span><br><span style="color: hsl(0, 100%, 40%);">-                               const uint8_t *data, uint8_t data_len_in)</span><br><span style="color: hsl(120, 100%, 40%);">+                             const uint8_t *data, uint16_t data_len_in)</span><br><span> {</span><br><span>  struct msgb *msg = st_msgb_alloc();</span><br><span>  struct cardemu_usb_msg_tx_data *txd;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11363">change 11363</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11363"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-remsim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Id38f9e597ffff242e89ea3dd9fbdf0c9f444cc03 </div>
<div style="display:none"> Gerrit-Change-Number: 11363 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>