<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11325">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libosmogsm/gsup.c: assert message type in osmo_gsup_encode()<br><br>Missing (unset) type of to be encoded message is not a memory<br>allocation failure (-ENOMEM), this is definitely a mistake.<br><br>Change-Id: Ibbac18e2b68b765c17c2bc959c4c085037953a7f<br>---<br>M src/gsm/gsup.c<br>1 file changed, 1 insertion(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/25/11325/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/gsup.c b/src/gsm/gsup.c</span><br><span>index 9c2f817..fe13d95 100644</span><br><span>--- a/src/gsm/gsup.c</span><br><span>+++ b/src/gsm/gsup.c</span><br><span>@@ -534,9 +534,7 @@</span><br><span>        size_t bcd_len;</span><br><span> </span><br><span>  /* generic part */</span><br><span style="color: hsl(0, 100%, 40%);">-      if(!gsup_msg->message_type)</span><br><span style="color: hsl(0, 100%, 40%);">-          return -ENOMEM;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+       OSMO_ASSERT(gsup_msg->message_type != 0x00);</span><br><span>      msgb_v_put(msg, gsup_msg->message_type);</span><br><span> </span><br><span>      bcd_len = gsm48_encode_bcd_number(bcd_buf, sizeof(bcd_buf), 0,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11325">change 11325</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11325"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ibbac18e2b68b765c17c2bc959c4c085037953a7f </div>
<div style="display:none"> Gerrit-Change-Number: 11325 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>