<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11334">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mgcp: osmux_send_dummy: Avoid logging incorrectly and sending if osmux not enabled<br><br>Change-Id: I5244cb9304adef3aa612b8126bf95e77562c801c<br>---<br>M openbsc/src/libmgcp/mgcp_osmux.c<br>1 file changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/34/11334/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/openbsc/src/libmgcp/mgcp_osmux.c b/openbsc/src/libmgcp/mgcp_osmux.c</span><br><span>index 71e8eae..33f5721 100644</span><br><span>--- a/openbsc/src/libmgcp/mgcp_osmux.c</span><br><span>+++ b/openbsc/src/libmgcp/mgcp_osmux.c</span><br><span>@@ -530,12 +530,20 @@</span><br><span>                      LOGP(DMGCP, LOGL_ERROR,</span><br><span>                           "Could not activate osmux in endpoint 0x%x\n",</span><br><span>                             ENDPOINT_NUMBER(endp));</span><br><span style="color: hsl(120, 100%, 40%);">+                  return 0;</span><br><span>            }</span><br><span>            LOGP(DMGCP, LOGL_ERROR,</span><br><span>                   "Osmux CID %u for %s:%u is now enabled\n",</span><br><span>                 endp->osmux.cid, inet_ntoa(endp->net_end.addr),</span><br><span>                endp->cfg->osmux_port);</span><br><span>   }</span><br><span style="color: hsl(120, 100%, 40%);">+     if(endp->osmux.state != OSMUX_STATE_ENABLED) {</span><br><span style="color: hsl(120, 100%, 40%);">+             LOGP(DMGCP, LOGL_ERROR,</span><br><span style="color: hsl(120, 100%, 40%);">+                    "OSMUX dummy to %s CID %u: Osmux not enabled on endpoint 0x%x state %d\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                  inet_ntoa(endp->net_end.addr), endp->osmux.cid,</span><br><span style="color: hsl(120, 100%, 40%);">+                 ENDPOINT_NUMBER(endp), endp->osmux.state);</span><br><span style="color: hsl(120, 100%, 40%);">+                 return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+        }</span><br><span>    LOGP(DMGCP, LOGL_DEBUG,</span><br><span>           "sending OSMUX dummy load to %s CID %u\n",</span><br><span>         inet_ntoa(endp->net_end.addr), endp->osmux.cid);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11334">change 11334</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11334"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: openbsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5244cb9304adef3aa612b8126bf95e77562c801c </div>
<div style="display:none"> Gerrit-Change-Number: 11334 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>