<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11232">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">store gsup peer upon accepting LU<br><br>Store the GSUP client's IPA_IDTAG_SERNR in vlr_number or sgsn_number (depending<br>on is_ps), just before sending the Insert Subscriber Data message after a<br>successful LU Req. Log about it.<br><br>Original patch: Ib2611421f3638eadc361787af801fffe9a34bd8a by laforge<br>Related: OS#2796<br><br>Change-Id: If438664faa5d68404f465f8b2002c6d03bbf3ceb<br>---<br>M src/hlr.c<br>1 file changed, 12 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/hlr.c b/src/hlr.c</span><br><span>index f631d52..26be8d5 100644</span><br><span>--- a/src/hlr.c</span><br><span>+++ b/src/hlr.c</span><br><span>@@ -242,12 +242,15 @@</span><br><span> static int rx_upd_loc_req(struct osmo_gsup_conn *conn,</span><br><span>                        const struct osmo_gsup_message *gsup)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+  struct hlr_subscriber *subscr;</span><br><span>       struct lu_operation *luop = lu_op_alloc_conn(conn);</span><br><span>  if (!luop) {</span><br><span>                 LOGP(DMAIN, LOGL_ERROR, "LU REQ from conn without addr?\n");</span><br><span>               return -EINVAL;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ subscr = &luop->subscr;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     lu_op_statechg(luop, LU_S_LU_RECEIVED);</span><br><span> </span><br><span>  switch (gsup->cn_domain) {</span><br><span>@@ -298,6 +301,15 @@</span><br><span>                 lu_op_tx_cancel_old(luop);</span><br><span>   } else</span><br><span> #endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+    /* Store the VLR / SGSN number with the subscriber, so we know where it was last seen. */</span><br><span style="color: hsl(120, 100%, 40%);">+     LOGP(DAUC, LOGL_DEBUG, "IMSI='%s': storing %s = %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+           subscr->imsi, luop->is_ps ? "SGSN number" : "VLR number",</span><br><span style="color: hsl(120, 100%, 40%);">+           osmo_quote_str((const char*)luop->peer, -1));</span><br><span style="color: hsl(120, 100%, 40%);">+ if (db_subscr_lu(g_hlr->dbc, subscr->id, (const char *)luop->peer, luop->is_ps))</span><br><span style="color: hsl(120, 100%, 40%);">+          LOGP(DAUC, LOGL_ERROR, "IMSI='%s': Cannot update %s in the database\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                  subscr->imsi, luop->is_ps ? "SGSN number" : "VLR number");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  {</span><br><span>            /* TODO: Subscriber allowed to roam in PLMN? */</span><br><span>              /* TODO: Update RoutingInfo */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11232">change 11232</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11232"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: If438664faa5d68404f465f8b2002c6d03bbf3ceb </div>
<div style="display:none"> Gerrit-Change-Number: 11232 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>