<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11316">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover_decision_2.c: tweak coments<br><br>Change-Id: I8bae3431dfaf23301e72f8f572286753b63a99b9<br>---<br>M src/osmo-bsc/handover_decision_2.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/16/11316/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c</span><br><span>index 4e9b02c..70be050 100644</span><br><span>--- a/src/osmo-bsc/handover_decision_2.c</span><br><span>+++ b/src/osmo-bsc/handover_decision_2.c</span><br><span>@@ -471,6 +471,7 @@</span><br><span>              break;</span><br><span>       default:</span><br><span>             LOGPHOLCHANTOBTS(lchan, bts, LOGL_DEBUG, "Not even considering: src is not a SPEECH mode lchan\n");</span><br><span style="color: hsl(120, 100%, 40%);">+         /* FIXME: should allow handover of non-speech lchans */</span><br><span>              return 0;</span><br><span>    }</span><br><span> </span><br><span>@@ -556,7 +557,7 @@</span><br><span>  }</span><br><span> #endif</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* the maximum number of unsynchonized handovers must no be exceeded */</span><br><span style="color: hsl(120, 100%, 40%);">+       /* the maximum number of unsynchronized handovers must no be exceeded */</span><br><span>     if (current_bts != bts</span><br><span>           && bts_handover_count(bts, HO_SCOPE_ALL) >= ho_get_hodec2_ho_max(bts->ho)) {</span><br><span>               LOGPHOLCHANTOBTS(lchan, bts, LOGL_DEBUG,</span><br><span>@@ -679,7 +680,7 @@</span><br><span>       return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* debug collected candidates */</span><br><span style="color: hsl(120, 100%, 40%);">+/* verbosely log about a handover candidate */</span><br><span> static inline void debug_candidate(struct gsm_lchan *lchan, struct ho_candidate *candidate,</span><br><span>    struct gsm_bts *neighbor, int8_t rxlev, int tchf_count, int tchh_count)</span><br><span> {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11316">change 11316</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11316"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8bae3431dfaf23301e72f8f572286753b63a99b9 </div>
<div style="display:none"> Gerrit-Change-Number: 11316 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>