<p>Stefan Sperling has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11292">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">resolve ambiguity of MobileIdentityLV type name<br><br>There are two distinct types defined for a Mobile Identity LV IE.<br><br>One type definition lives in GSM_RR_Types and defines the "canonical"<br>IE form, with a full octet for the length.<br><br>Another one lives in RLCMAC_CSN1_Types which defines how a mobile<br>identity appears in paging requests. In this case, the length field<br>is only 4 bits in size. Rename this latter type from MobileIdentityLV to<br>MobileIdentityLV_Paging and add a comment to highlight this distinction.<br>TS 144 060 Table 11.2.10.2 explicitly states that only the value<br>part of this IE matches the definition of the canonical IE as<br>"defined in 3GPP TS 44.018" (actually, TS 44.018 further redirects<br>the reader to TS 124 008; see section 10.5.1.4 there).<br><br>As an aside, a third definition of the MobileIdentityLV type exists<br>in MobileL3_CommonIE_Types, which matches the "canonical" form.<br><br>Change-Id: I990316cd5ef5aaf079b03c344e3185ae6ab8ba6d<br>Related: OS#2404<br>---<br>M library/GSM_RR_Types.ttcn<br>M library/RLCMAC_CSN1_Types.ttcn<br>2 files changed, 8 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/11292/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn</span><br><span>index 675271f..26783f9 100644</span><br><span>--- a/library/GSM_RR_Types.ttcn</span><br><span>+++ b/library/GSM_RR_Types.ttcn</span><br><span>@@ -231,6 +231,7 @@</span><br><span> variant "FIELDORDER(lsb)"</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* TS 24.008 10.5.1.4 "Mobile Identity" */</span><br><span> type record MobileIdentityLV {</span><br><span> uint8_t len,</span><br><span> MobileIdentity mi</span><br><span>diff --git a/library/RLCMAC_CSN1_Types.ttcn b/library/RLCMAC_CSN1_Types.ttcn</span><br><span>index fbd01d4..9a7c867 100644</span><br><span>--- a/library/RLCMAC_CSN1_Types.ttcn</span><br><span>+++ b/library/RLCMAC_CSN1_Types.ttcn</span><br><span>@@ -185,7 +185,11 @@</span><br><span> };</span><br><span> </span><br><span> /* 11.2.10 Packet Paging Request */</span><br><span style="color: hsl(0, 100%, 40%);">- type record MobileIdentityLV {</span><br><span style="color: hsl(120, 100%, 40%);">+ type record MobileIdentityLV_Paging {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Note that the size of 'len' differs from that of the Mobile Identify IE</span><br><span style="color: hsl(120, 100%, 40%);">+ * as defined in 3GPP TS 24.008 10.5.1.4 "Mobile Identity"; Paging Requests</span><br><span style="color: hsl(120, 100%, 40%);">+ * use only 4 bit to encode the length of a mobile identity, whereas the IE</span><br><span style="color: hsl(120, 100%, 40%);">+ * uses a byte. */</span><br><span> uint4_t len,</span><br><span> octetstring mobile_id</span><br><span> } with { variant (len) "LENGTHTO(mobile_id)" };</span><br><span>@@ -193,7 +197,7 @@</span><br><span> BIT1 presence ('0'B),</span><br><span> BIT1 ptmsi_or_mobile_id,</span><br><span> GsmTmsi ptmsi optional,</span><br><span style="color: hsl(0, 100%, 40%);">- MobileIdentityLV mobile_identity optional</span><br><span style="color: hsl(120, 100%, 40%);">+ MobileIdentityLV_Paging mobile_identity optional</span><br><span> } with {</span><br><span> variant (ptmsi) "PRESENCE(ptmsi_or_mobile_id = '0'B)"</span><br><span> variant (mobile_identity) "PRESENCE(ptmsi_or_mobile_id = '1'B)"</span><br><span>@@ -202,7 +206,7 @@</span><br><span> BIT1 presence ('1'B),</span><br><span> BIT1 tmsi_or_mobile_id,</span><br><span> GsmTmsi tmsi optional,</span><br><span style="color: hsl(0, 100%, 40%);">- MobileIdentityLV mobile_identity optional,</span><br><span style="color: hsl(120, 100%, 40%);">+ MobileIdentityLV_Paging mobile_identity optional,</span><br><span> ChannelNeeded chan_needed,</span><br><span> BIT1 emlpp_prio_present,</span><br><span> uint3_t emlpp_prio optional</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11292">change 11292</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11292"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I990316cd5ef5aaf079b03c344e3185ae6ab8ba6d </div>
<div style="display:none"> Gerrit-Change-Number: 11292 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>