<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11277">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Use enum for PKT_LINK_*<br><br>Makes it easier to understand different types and how they relate to<br>same field.<br><br>Change-Id: I1bec4d5d132a1476f9c418502ad808b7c778cee2<br>---<br>M include/osmo-pcap/wireformat.h<br>1 file changed, 4 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/77/11277/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmo-pcap/wireformat.h b/include/osmo-pcap/wireformat.h</span><br><span>index 3f92ee8..54dce22 100644</span><br><span>--- a/include/osmo-pcap/wireformat.h</span><br><span>+++ b/include/osmo-pcap/wireformat.h</span><br><span>@@ -26,15 +26,10 @@</span><br><span> #include <inttypes.h></span><br><span> #include <pcap.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * Should send an entire pcap header</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-#define PKT_LINK_HDR      0</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * Should send one packet...</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-#define PKT_LINK_DATA 1</span><br><span style="color: hsl(120, 100%, 40%);">+enum OsmoPcapDataType {</span><br><span style="color: hsl(120, 100%, 40%);">+    PKT_LINK_HDR, /* Should send an entire pcap header */</span><br><span style="color: hsl(120, 100%, 40%);">+ PKT_LINK_DATA /* Should send one packet */</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span> </span><br><span> struct osmo_pcap_data {</span><br><span>        uint8_t type;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11277">change 11277</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11277"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcap </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1bec4d5d132a1476f9c418502ad808b7c778cee2 </div>
<div style="display:none"> Gerrit-Change-Number: 11277 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>