<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11180">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">firmware/layer1: inform about unhandled scheduler tasks<br><br>The mframe_task2chan_nr() is used to get the channel number<br>(encoded according to 08.58 Chapter 9.3.1) corresponding to<br>a given multi-frame task type.<br><br>It makes sense to at least print some debug message in cases<br>when there is no matching channel number for a given task type.<br><br>Change-Id: I34587b6c67015513de35d85a7a3291f452ee7f3b<br>---<br>M src/target/firmware/layer1/mframe_sched.c<br>1 file changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/target/firmware/layer1/mframe_sched.c b/src/target/firmware/layer1/mframe_sched.c</span><br><span>index f3a6b43..01ae167 100644</span><br><span>--- a/src/target/firmware/layer1/mframe_sched.c</span><br><span>+++ b/src/target/firmware/layer1/mframe_sched.c</span><br><span>@@ -400,10 +400,12 @@</span><br><span>    case MF_TASK_TCH_H_1:</span><br><span>                cbits = 0x02 + 1;</span><br><span>            break;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     case MF_TASK_UL_ALL_NB:</span><br><span style="color: hsl(0, 100%, 40%);">-         /* ERROR: cannot express as channel number */</span><br><span style="color: hsl(0, 100%, 40%);">-           cbits = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-              break;</span><br><span style="color: hsl(120, 100%, 40%);">+        default:</span><br><span style="color: hsl(120, 100%, 40%);">+              printd("ERROR: cannot express mf_task=%d as "</span><br><span style="color: hsl(120, 100%, 40%);">+                       "channel number, using 0x00\n", mft);</span><br><span style="color: hsl(120, 100%, 40%);">+               cbits = 0x00;</span><br><span>        }</span><br><span> </span><br><span>        return (cbits << 3) | (ts & 0x7);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11180">change 11180</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11180"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I34587b6c67015513de35d85a7a3291f452ee7f3b </div>
<div style="display:none"> Gerrit-Change-Number: 11180 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>