<p>Keith Whyte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11193">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Logging: Further use of osmo_mncc_name() in logging<br><br>Use osmo_mncc_name() in timer functions and in logging<br>the type of MNCC message sent to the socket.<br><br>Change-Id: Ic77e0d86c91c29ff7304e620fdecb69b22127d33<br>---<br>M src/mncc.c<br>1 file changed, 6 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/93/11193/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mncc.c b/src/mncc.c</span><br><span>index 1b44e05..976a671 100644</span><br><span>--- a/src/mncc.c</span><br><span>+++ b/src/mncc.c</span><br><span>@@ -65,20 +65,21 @@</span><br><span> </span><br><span>   leg->cmd_timeout.cb = cmd_timeout;</span><br><span>        leg->cmd_timeout.data = leg;</span><br><span style="color: hsl(120, 100%, 40%);">+       LOGP(DMNCC, LOGL_DEBUG, "Starting Timer for %s\n", osmo_mncc_name(expected_next));</span><br><span>         osmo_timer_schedule(&leg->cmd_timeout, 5, 0);</span><br><span> }</span><br><span> </span><br><span> static void stop_cmd_timer(struct mncc_call_leg *leg, uint32_t got_res)</span><br><span> {</span><br><span>        if (leg->rsp_wanted != got_res) {</span><br><span style="color: hsl(0, 100%, 40%);">-            LOGP(DMNCC, LOGL_ERROR, "Wanted rsp(%u) but got(%u) for leg(%u)\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                   leg->rsp_wanted, got_res, leg->callref);</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGP(DMNCC, LOGL_ERROR, "Wanted rsp(%s) but got(%s) for leg(%u)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                 osmo_mncc_name(leg->rsp_wanted), osmo_mncc_name(got_res), leg->callref);</span><br><span>               return;</span><br><span>      }</span><br><span> </span><br><span>        LOGP(DMNCC, LOGL_DEBUG,</span><br><span style="color: hsl(0, 100%, 40%);">-         "Got response(0x%x), stopping timer on leg(%u)\n",</span><br><span style="color: hsl(0, 100%, 40%);">-            got_res, leg->callref);</span><br><span style="color: hsl(120, 100%, 40%);">+            "Got response(%s), stopping timer on leg(%u)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+            osmo_mncc_name(got_res), leg->callref);</span><br><span>   osmo_timer_del(&leg->cmd_timeout);</span><br><span> }</span><br><span> </span><br><span>@@ -127,6 +128,7 @@</span><br><span>      * static struct?</span><br><span>     */</span><br><span>  rc = write(conn->fd.fd, mncc, sizeof(*mncc));</span><br><span style="color: hsl(120, 100%, 40%);">+      LOGP(DMNCC, LOGL_DEBUG, "MNCC sent message type: %s\n", osmo_mncc_name(mncc->msg_type));</span><br><span>        if (rc != sizeof(*mncc)) {</span><br><span>           LOGP(DMNCC, LOGL_ERROR, "Failed to send message call(%u)\n", callref);</span><br><span>             close_connection(conn);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11193">change 11193</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11193"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic77e0d86c91c29ff7304e620fdecb69b22127d33 </div>
<div style="display:none"> Gerrit-Change-Number: 11193 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Keith Whyte <keith@rhizomatica.org> </div>