<p><a href="https://gerrit.osmocom.org/11181">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/11181/2/src/target/firmware/layer1/mframe_sched.c">File src/target/firmware/layer1/mframe_sched.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/11181/2/src/target/firmware/layer1/mframe_sched.c@418">Patch Set #2, Line 418:</a> <code style="font-family:monospace,monospace">        case MF_TASK_SDCCH4_CBCH:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Oh, I think there should be a way to distinguish between both<br>tasks. What about the following:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  - MF_TASK_SDCCH4_CBCH - 0xc0 (0b11000 000)<br>  - MF_TASK_SDCCH8_CBCH - 0xc8 (0b11001 000)</pre><p style="white-space: pre-wrap; word-wrap: break-word;">The problem is that the following assumption:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  mf_task = (tn == 0) ?<br>    MF_TASK_SDCCH4_CBCH : MF_TASK_SDCCH8_CBCH;</pre><p style="white-space: pre-wrap; word-wrap: break-word;">is wrong, because SDCCH/8 can also be allocated on CX/TS0.<br>We need to find some way to distinguish both cases...</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/11181">change 11181</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11181"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I1d7f02cba1cd8f6527360589d2d2747b6426f78b </div>
<div style="display:none"> Gerrit-Change-Number: 11181 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 01 Oct 2018 20:18:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>