<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11159">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">*.py: cosmetic: tweak the global logging format<br><br>Printing log level, file name, and line number together with a<br>log message is the common practice in Osmocom projects that<br>facilitates debugging and development.<br><br>Change-Id: I80cd7cdfa41ae7e70a1890d88c8b2f7357a500af<br>---<br>M contrib/manual_test_server.py<br>M mncc_test.py<br>M smpp_test.py<br>3 files changed, 9 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/mncc-python refs/changes/59/11159/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/contrib/manual_test_server.py b/contrib/manual_test_server.py</span><br><span>index 5625670..d92eb84 100644</span><br><span>--- a/contrib/manual_test_server.py</span><br><span>+++ b/contrib/manual_test_server.py</span><br><span>@@ -3,6 +3,8 @@</span><br><span> import ctypes</span><br><span> import socket</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+import logging as log</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> GSM340_PLAN_ISDN = 1</span><br><span> GSM340_TYPE_NATIONAL = 2</span><br><span> </span><br><span>@@ -80,6 +82,9 @@</span><br><span>     conn.send_msg(MnccMessageBuilder.build_dtmf_stop(callref, '2'))</span><br><span> </span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+log.basicConfig(level = log.DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+    format = "%(levelname)s %(filename)s:%(lineno)d %(message)s")</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> server = mncc_sock.MnccSocketServer()</span><br><span> conn = server.accept()</span><br><span> </span><br><span>diff --git a/mncc_test.py b/mncc_test.py</span><br><span>index df66efb..9222605 100755</span><br><span>--- a/mncc_test.py</span><br><span>+++ b/mncc_test.py</span><br><span>@@ -48,7 +48,8 @@</span><br><span>     pykka.ActorRegistry.stop_all()</span><br><span>     sys.exit(0)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-logging.basicConfig(level=logging.DEBUG)</span><br><span style="color: hsl(120, 100%, 40%);">+logging.basicConfig(level = logging.DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+    format = "%(levelname)s %(filename)s:%(lineno)d %(message)s")</span><br><span> </span><br><span> signal.signal(signal.SIGINT, sigint_handler)</span><br><span> </span><br><span>diff --git a/smpp_test.py b/smpp_test.py</span><br><span>index 181f60d..ad7d4dc 100755</span><br><span>--- a/smpp_test.py</span><br><span>+++ b/smpp_test.py</span><br><span>@@ -11,7 +11,8 @@</span><br><span> # to generate some SMS load on OsmoNITB via its SMPP interface</span><br><span> </span><br><span> # if you want to know what's happening</span><br><span style="color: hsl(0, 100%, 40%);">-logging.basicConfig(level='DEBUG')</span><br><span style="color: hsl(120, 100%, 40%);">+logging.basicConfig(level = logging.DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+    format = "%(levelname)s %(filename)s:%(lineno)d %(message)s")</span><br><span> </span><br><span> def send_message(dest, string):</span><br><span>     parts, encoding_flag, msg_type_flag = smpplib.gsm.make_parts(string)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11159">change 11159</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11159"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: mncc-python </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I80cd7cdfa41ae7e70a1890d88c8b2f7357a500af </div>
<div style="display:none"> Gerrit-Change-Number: 11159 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>