<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11155">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved; Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mncc_sock.py: simplify msg_type matching<br><br>Change-Id: I0d7d988e7d1bcfd9cf5cd319fd9da0f4f65a8e5d<br>---<br>M mncc_sock.py<br>1 file changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/mncc_sock.py b/mncc_sock.py</span><br><span>index 9887471..1c4f6be 100644</span><br><span>--- a/mncc_sock.py</span><br><span>+++ b/mncc_sock.py</span><br><span>@@ -22,6 +22,11 @@</span><br><span>         fit = min(len(bytes), ctypes.sizeof(self))</span><br><span>         ctypes.memmove(ctypes.addressof(self), bytes, fit)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    # Message type matching</span><br><span style="color: hsl(120, 100%, 40%);">+    def is_rtp(self):</span><br><span style="color: hsl(120, 100%, 40%);">+        return self.msg_type in (mncc.MNCC_RTP_CREATE,</span><br><span style="color: hsl(120, 100%, 40%);">+            mncc.MNCC_RTP_CONNECT, mncc.MNCC_RTP_FREE)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> class mncc_msg(mncc.gsm_mncc, mncc_msg_common):</span><br><span>     def __str__(self):</span><br><span>         return 'mncc_msg(type=0x%04x, callref=%u, fields=0x%04x)' % (self.msg_type, self.callref, self.fields)</span><br><span>@@ -75,7 +80,7 @@</span><br><span>         data = self.sock.recv(1500)</span><br><span>         ms = mncc_msg()</span><br><span>         ms.receive(data)</span><br><span style="color: hsl(0, 100%, 40%);">-        if ms.msg_type == mncc.MNCC_RTP_CREATE or ms.msg_type == mncc.MNCC_RTP_CONNECT or ms.msg_type == mncc.MNCC_RTP_FREE:</span><br><span style="color: hsl(120, 100%, 40%);">+        if ms.is_rtp():</span><br><span>                ms = mncc_rtp_msg()</span><br><span>                ms.receive(data)</span><br><span>         elif ms.msg_type == mncc.MNCC_SOCKET_HELLO:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11155">change 11155</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11155"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: mncc-python </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0d7d988e7d1bcfd9cf5cd319fd9da0f4f65a8e5d </div>
<div style="display:none"> Gerrit-Change-Number: 11155 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>