<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/11148">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/11148/1/bts/BTS_Tests.ttcn">File bts/BTS_Tests.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/11148/1/bts/BTS_Tests.ttcn@1169">Patch Set #1, Line 1169:</a> <code style="font-family:monospace,monospace">                 l1header := valueof(ts_SACCH_L1_HEADER(g_pars.l1_pars.ms_power_level, false, g_pars.l1_pars.ms_actual_ta)),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Also, I think it makes sense to use the parameters from L1<br>SACCH pseudo-header indicated on DL, i.e. from 'l1_dl'.</p><p style="white-space: pre-wrap; word-wrap: break-word;">In the normal OsmocomBB setup, the SI 5/5ter/6 messages<br>are being forwarded from L1 to the higher layers, which<br>then instruct L1 via L1CTL_PARAM_REQ.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/11148">change 11148</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11148"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iedab8681a0ba4652a6bb1c001418599a4ff746b6 </div>
<div style="display:none"> Gerrit-Change-Number: 11148 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 28 Sep 2018 16:34:46 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>