<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11124">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">neighbor vty: drop keyword 'add'<br><br>When writing the neighbor configuration documentation, I noticed that 'neighbor<br>add' and 'neighbor del' make sense from an interactive VTY POV, but when<br>looking at a static config file, it makes more sense to simply name the<br>neighbors without the 'add' keyword, and to use the 'no' prefix instead of the<br>'del' keyword. It still makes sense to tweak cosmetics like this before<br>inter-bsc handover is used anywhere.<br><br>First, remove 'add' from all 'neighbor add ...' commands.<br><br>Instead, prepend "Add" to the doc string for the cell identification argument<br>in commands that add a neighbor:<br><br> -OsmoBSC(config-net-bts)# neighbor add ?<br> - bts Neighbor cell by local BTS number<br> +OsmoBSC(config-net-bts)# neighbor ?<br> + bts Add Neighbor cell by local BTS number<br><br>(A subsequent patch will rename 'neighbor del' to 'no neighbor'.)<br><br>Change-Id: I143f21f6069d1a86096cc8240cf69eb7ea9c8ac8<br>---<br>M src/osmo-bsc/neighbor_ident_vty.c<br>M tests/neighbor_ident.vty<br>2 files changed, 111 insertions(+), 113 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/24/11124/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/neighbor_ident_vty.c b/src/osmo-bsc/neighbor_ident_vty.c</span><br><span>index 28f4afd..8db9db7 100644</span><br><span>--- a/src/osmo-bsc/neighbor_ident_vty.c</span><br><span>+++ b/src/osmo-bsc/neighbor_ident_vty.c</span><br><span>@@ -68,10 +68,10 @@</span><br><span> return true;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define NEIGHBOR_ADD_CMD "neighbor add "</span><br><span style="color: hsl(120, 100%, 40%);">+#define NEIGHBOR_ADD_CMD "neighbor "</span><br><span> #define NEIGHBOR_DEL_CMD "neighbor del "</span><br><span style="color: hsl(0, 100%, 40%);">-#define NEIGHBOR_DOC "Neighbor cell list\n"</span><br><span style="color: hsl(0, 100%, 40%);">-#define NEIGHBOR_ADD_DOC NEIGHBOR_DOC "Add local or remote-BSS neighbor cell\n"</span><br><span style="color: hsl(120, 100%, 40%);">+#define NEIGHBOR_DOC "Manage local and remote-BSS neighbor cells\n"</span><br><span style="color: hsl(120, 100%, 40%);">+#define NEIGHBOR_ADD_DOC NEIGHBOR_DOC "Add "</span><br><span> #define NEIGHBOR_DEL_DOC NEIGHBOR_DOC "Remove local or remote-BSS neighbor cell\n"</span><br><span> </span><br><span> #define LAC_PARAMS "lac <0-65535>"</span><br><span>@@ -431,7 +431,7 @@</span><br><span> return true;</span><br><span> </span><br><span> #define NEIGH_BSS_WRITE(fmt, args...) do { \</span><br><span style="color: hsl(0, 100%, 40%);">- vty_out(vty, "%sneighbor add " fmt " arfcn %u ", d->indent, ## args, key->arfcn); \</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "%sneighbor " fmt " arfcn %u ", d->indent, ## args, key->arfcn); \</span><br><span> if (key->bsic == BSIC_ANY) \</span><br><span> vty_out(vty, "bsic any"); \</span><br><span> else \</span><br><span>@@ -485,7 +485,7 @@</span><br><span> struct gsm_bts_ref *neigh;</span><br><span> </span><br><span> llist_for_each_entry(neigh, &bts->local_neighbors, entry) {</span><br><span style="color: hsl(0, 100%, 40%);">- vty_out(vty, "%sneighbor add lac-ci %u %u%s",</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "%sneighbor lac-ci %u %u%s",</span><br><span> indent, neigh->bts->location_area_code, neigh->bts->cell_identity,</span><br><span> VTY_NEWLINE);</span><br><span> }</span><br><span>diff --git a/tests/neighbor_ident.vty b/tests/neighbor_ident.vty</span><br><span>index dadbe13..644e330 100644</span><br><span>--- a/tests/neighbor_ident.vty</span><br><span>+++ b/tests/neighbor_ident.vty</span><br><span>@@ -80,84 +80,81 @@</span><br><span> OsmoBSC(config-net)# bts 0</span><br><span> OsmoBSC(config-net-bts)# list</span><br><span> ...</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add bts <0-255></span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac <0-65535></span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci <0-65535> <0-65535></span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac <0-65535> arfcn <0-1023> bsic (<0-63>|any)</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci <0-65535> <0-65535> arfcn <0-1023> bsic (<0-63>|any)</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add cgi <0-999> <0-999> <0-65535> <0-65535> arfcn <0-1023> bsic (<0-63>|any)</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor bts <0-255></span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac <0-65535></span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci <0-65535> <0-65535></span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac <0-65535> arfcn <0-1023> bsic (<0-63>|any)</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci <0-65535> <0-65535> arfcn <0-1023> bsic (<0-63>|any)</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor cgi <0-999> <0-999> <0-65535> <0-65535> arfcn <0-1023> bsic (<0-63>|any)</span><br><span> neighbor del bts <0-255></span><br><span> neighbor del arfcn <0-1023> bsic (<0-63>|any)</span><br><span> ...</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# neighbor?</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor Neighbor cell list</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor Manage local and remote-BSS neighbor cells</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# neighbor ?</span><br><span style="color: hsl(0, 100%, 40%);">- add Add local or remote-BSS neighbor cell</span><br><span style="color: hsl(0, 100%, 40%);">- del Remove local or remote-BSS neighbor cell</span><br><span style="color: hsl(120, 100%, 40%);">+ bts Add Neighbor cell by local BTS number</span><br><span style="color: hsl(120, 100%, 40%);">+ lac Add Neighbor cell by LAC</span><br><span style="color: hsl(120, 100%, 40%);">+ lac-ci Add Neighbor cell by LAC and CI</span><br><span style="color: hsl(120, 100%, 40%);">+ cgi Add Neighbor cell by cgi</span><br><span style="color: hsl(120, 100%, 40%);">+ del Remove local or remote-BSS neighbor cell</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add ?</span><br><span style="color: hsl(0, 100%, 40%);">- bts Neighbor cell by local BTS number</span><br><span style="color: hsl(0, 100%, 40%);">- lac Neighbor cell by LAC</span><br><span style="color: hsl(0, 100%, 40%);">- lac-ci Neighbor cell by LAC and CI</span><br><span style="color: hsl(0, 100%, 40%);">- cgi Neighbor cell by cgi</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add bts ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor bts ?</span><br><span> <0-255> BTS number</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add bts 0 ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor bts 0 ?</span><br><span> <cr> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac ?</span><br><span> <0-65535> LAC</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac 0 ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac 0 ?</span><br><span> arfcn ARFCN of neighbor cell</span><br><span> <cr> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac 0 arfcn ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac 0 arfcn ?</span><br><span> <0-1023> ARFCN value</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac 0 arfcn 0 ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac 0 arfcn 0 ?</span><br><span> bsic BSIC of neighbor cell</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac 0 arfcn 0 bsic ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac 0 arfcn 0 bsic ?</span><br><span> <0-63> BSIC value</span><br><span> any for all BSICs / use any BSIC in this ARFCN</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac 0 arfcn 0 bsic 0 ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac 0 arfcn 0 bsic 0 ?</span><br><span> <cr> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac-ci ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac-ci ?</span><br><span> <0-65535> LAC</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac-ci 0 ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac-ci 0 ?</span><br><span> <0-65535> CI</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac-ci 0 0 ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac-ci 0 0 ?</span><br><span> arfcn ARFCN of neighbor cell</span><br><span> <cr> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac-ci 0 0 arfcn ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac-ci 0 0 arfcn ?</span><br><span> <0-1023> ARFCN value</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac-ci 0 0 arfcn 0 ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac-ci 0 0 arfcn 0 ?</span><br><span> bsic BSIC of neighbor cell</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac-ci 0 0 arfcn 0 bsic ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac-ci 0 0 arfcn 0 bsic ?</span><br><span> <0-63> BSIC value</span><br><span> any for all BSICs / use any BSIC in this ARFCN</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac-ci 0 0 arfcn 0 bsic 0 ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac-ci 0 0 arfcn 0 bsic 0 ?</span><br><span> <cr> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi ?</span><br><span> <0-999> MCC</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi 0 ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi 0 ?</span><br><span> <0-999> MNC</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi 0 0 ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi 0 0 ?</span><br><span> <0-65535> LAC</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi 0 0 0 ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi 0 0 0 ?</span><br><span> <0-65535> CI</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi 0 0 0 0 ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi 0 0 0 0 ?</span><br><span> arfcn ARFCN of neighbor cell</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi 0 0 0 0 arfcn ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi 0 0 0 0 arfcn ?</span><br><span> <0-1023> ARFCN value</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi 0 0 0 0 arfcn 0 ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi 0 0 0 0 arfcn 0 ?</span><br><span> bsic BSIC of neighbor cell</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi 0 0 0 0 arfcn 0 bsic ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi 0 0 0 0 arfcn 0 bsic ?</span><br><span> <0-63> BSIC value</span><br><span> any for all BSICs / use any BSIC in this ARFCN</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi 0 0 0 0 arfcn 0 bsic 0 ?</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi 0 0 0 0 arfcn 0 bsic 0 ?</span><br><span> <cr> </span><br><span> </span><br><span> OsmoBSC(config-net-bts)# neighbor del ?</span><br><span>@@ -180,72 +177,73 @@</span><br><span> <cr> </span><br><span> </span><br><span> OsmoBSC(config-net-bts)# show running-config</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi 23 42 423 5 arfcn 23 bsic 64</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# ! BSIC out of range</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi 23 42 423 5 arfcn 23 bsic 64</span><br><span> % Unknown command.</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add bts 0</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor bts 0</span><br><span> % Error: cannot add local BTS 0 as neighbor to BTS 0: Invalid argument</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# show running-config</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add bts 1</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor bts 1</span><br><span> % BTS 0 now has local neighbor BTS 1 with LAC 21 CI 31 and ARFCN 41 BSIC 11</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac 22</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac 22</span><br><span> % BTS 0 now has local neighbor BTS 2 with LAC 22 CI 65535 and ARFCN 42 BSIC 12</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi 23 42 423 5 arfcn 23 bsic 42</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi 23 42 423 5 arfcn 23 bsic 42</span><br><span> % BTS 0 to ARFCN 23 BSIC 42 now has 1 remote BSS Cell Identifier List entry</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# ### adding the same entry again results in no change</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add bts 1</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor bts 1</span><br><span> % BTS 0 already had local neighbor BTS 1 with LAC 21 CI 31 and ARFCN 41 BSIC 11</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac-ci 21 31</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac-ci 21 31</span><br><span> % BTS 0 already had local neighbor BTS 1 with LAC 21 CI 31 and ARFCN 41 BSIC 11</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi 23 42 423 5 arfcn 23 bsic 42</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi 23 42 423 5 arfcn 23 bsic 42</span><br><span> % BTS 0 to ARFCN 23 BSIC 42 now has 1 remote BSS Cell Identifier List entry</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi 23 42 423 5 arfcn 23 bsic 42</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi 23 42 423 5 arfcn 23 bsic 42</span><br><span> % BTS 0 to ARFCN 23 BSIC 42 now has 1 remote BSS Cell Identifier List entry</span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi 23 42 423 5 arfcn 23 bsic 42</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi 23 42 423 5 arfcn 23 bsic 42</span><br><span> % BTS 0 to ARFCN 23 BSIC 42 now has 1 remote BSS Cell Identifier List entry</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi 23 042 423 6 arfcn 23 bsic 42</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi 23 042 423 6 arfcn 23 bsic 42</span><br><span> % BTS 0 to ARFCN 23 BSIC 42 now has 2 remote BSS Cell Identifier List entries</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac 456 arfcn 123 bsic 45</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac 456 arfcn 123 bsic 45</span><br><span> % BTS 0 to ARFCN 123 BSIC 45 now has 1 remote BSS Cell Identifier List entry</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add cgi 23 042 234 56 arfcn 23 bsic 42</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor cgi 23 042 234 56 arfcn 23 bsic 42</span><br><span> % BTS 0 to ARFCN 23 BSIC 42 now has 3 remote BSS Cell Identifier List entries</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac-ci 789 10 arfcn 423 bsic any</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac-ci 789 10 arfcn 423 bsic any</span><br><span> % BTS 0 to ARFCN 423 (any BSIC) now has 1 remote BSS Cell Identifier List entry</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac-ci 789 10 arfcn 423 bsic 63</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac-ci 789 10 arfcn 423 bsic 63</span><br><span> % BTS 0 to ARFCN 423 BSIC 63 now has 1 remote BSS Cell Identifier List entry</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-OsmoBSC(config-net-bts)# neighbor add lac-ci 789 10 arfcn 423 bsic 1</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoBSC(config-net-bts)# neighbor lac-ci 789 10 arfcn 423 bsic 1</span><br><span> % BTS 0 to ARFCN 423 BSIC 1 now has 1 remote BSS Cell Identifier List entry</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# show running-config</span><br><span> ...</span><br><span> network</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span> bts 0</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 21 31</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 22 65535</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add cgi 023 42 423 5 arfcn 23 bsic 42</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add cgi 023 042 423 6 arfcn 23 bsic 42</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add cgi 023 042 234 56 arfcn 23 bsic 42</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac 456 arfcn 123 bsic 45</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 789 10 arfcn 423 bsic any</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 789 10 arfcn 423 bsic 63</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 789 10 arfcn 423 bsic 1</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 21 31</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 22 65535</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor cgi 023 42 423 5 arfcn 23 bsic 42</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor cgi 023 042 423 6 arfcn 23 bsic 42</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor cgi 023 042 234 56 arfcn 23 bsic 42</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac 456 arfcn 123 bsic 45</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 789 10 arfcn 423 bsic any</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 789 10 arfcn 423 bsic 63</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 789 10 arfcn 423 bsic 1</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span> </span><br><span> OsmoBSC(config-net-bts)# do show bts 0 neighbor arfcn 99 bsic any</span><br><span> % No entry for BTS 0 to ARFCN 99 (any BSIC)</span><br><span>@@ -254,10 +252,10 @@</span><br><span> % BTS 0 to ARFCN 41 (any BSIC) resolves to local BTS 1 lac-ci 21 31</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# do show bts 0 neighbor arfcn 423 bsic 1</span><br><span style="color: hsl(0, 100%, 40%);">-% neighbor add lac-ci 789 10 arfcn 423 bsic 1</span><br><span style="color: hsl(120, 100%, 40%);">+% neighbor lac-ci 789 10 arfcn 423 bsic 1</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# do show bts 0 neighbor arfcn 423 bsic 23</span><br><span style="color: hsl(0, 100%, 40%);">-% neighbor add lac-ci 789 10 arfcn 423 bsic 23</span><br><span style="color: hsl(120, 100%, 40%);">+% neighbor lac-ci 789 10 arfcn 423 bsic 23</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# neighbor del arfcn 99 bsic 7</span><br><span> % Cannot remove, no such neighbor: BTS 0 to ARFCN 99 BSIC 7</span><br><span>@@ -266,75 +264,75 @@</span><br><span> % Removed remote BSS neighbor BTS 0 to ARFCN 23 BSIC 42</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# show running-config</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 21 31</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 22 65535</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac 456 arfcn 123 bsic 45</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 789 10 arfcn 423 bsic any</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 789 10 arfcn 423 bsic 63</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 789 10 arfcn 423 bsic 1</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 21 31</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 22 65535</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac 456 arfcn 123 bsic 45</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 789 10 arfcn 423 bsic any</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 789 10 arfcn 423 bsic 63</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 789 10 arfcn 423 bsic 1</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span> </span><br><span> OsmoBSC(config-net-bts)# neighbor del arfcn 123 bsic 45</span><br><span> % Removed remote BSS neighbor BTS 0 to ARFCN 123 BSIC 45</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# show running-config</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 21 31</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 22 65535</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 789 10 arfcn 423 bsic any</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 789 10 arfcn 423 bsic 63</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 789 10 arfcn 423 bsic 1</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 21 31</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 22 65535</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 789 10 arfcn 423 bsic any</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 789 10 arfcn 423 bsic 63</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 789 10 arfcn 423 bsic 1</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span> </span><br><span> OsmoBSC(config-net-bts)# neighbor del arfcn 423 bsic any</span><br><span> % Removed remote BSS neighbor BTS 0 to ARFCN 423 (any BSIC)</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# show running-config</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 21 31</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 22 65535</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 789 10 arfcn 423 bsic 63</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 789 10 arfcn 423 bsic 1</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 21 31</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 22 65535</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 789 10 arfcn 423 bsic 63</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 789 10 arfcn 423 bsic 1</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span> </span><br><span> OsmoBSC(config-net-bts)# neighbor del arfcn 423 bsic 63</span><br><span> % Removed remote BSS neighbor BTS 0 to ARFCN 423 BSIC 63</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# show running-config</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 21 31</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 22 65535</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 789 10 arfcn 423 bsic 1</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 21 31</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 22 65535</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 789 10 arfcn 423 bsic 1</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span> </span><br><span> OsmoBSC(config-net-bts)# neighbor del arfcn 423 bsic 1</span><br><span> % Removed remote BSS neighbor BTS 0 to ARFCN 423 BSIC 1</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# show running-config</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 21 31</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 22 65535</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 21 31</span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 22 65535</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span> </span><br><span> OsmoBSC(config-net-bts)# neighbor del arfcn 41 bsic any</span><br><span> % Removed local neighbor bts 0 to bts 1</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# show running-config</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 22 65535</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 22 65535</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span> </span><br><span> OsmoBSC(config-net-bts)# neighbor del arfcn 41 bsic any</span><br><span> % Cannot remove, no such neighbor: BTS 0 to ARFCN 41 (any BSIC)</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# show running-config</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(0, 100%, 40%);">- neighbor add lac-ci 22 65535</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span style="color: hsl(120, 100%, 40%);">+ neighbor lac-ci 22 65535</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span> </span><br><span> OsmoBSC(config-net-bts)# neighbor del arfcn 42 bsic 12</span><br><span> % Removed local neighbor bts 0 to bts 2</span><br><span> </span><br><span> OsmoBSC(config-net-bts)# show running-config</span><br><span style="color: hsl(0, 100%, 40%);">-... !neighbor add</span><br><span style="color: hsl(120, 100%, 40%);">+... !neighbor </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11124">change 11124</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11124"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I143f21f6069d1a86096cc8240cf69eb7ea9c8ac8 </div>
<div style="display:none"> Gerrit-Change-Number: 11124 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>