<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11059">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">assignment_fsm: only include speech codec (choosen) on AoIP networks<br><br>The field speech codec (choosen) in the ASSIGNMENT COMPLETE message<br>has been specified with AoIP. Since sccp-lite has been specified before<br>AoIP, we should not include the speech codec (choosen) field in the<br>ASSIGNMENT COMPLETE, when osmo-bsc is connected to an sccp-lite based<br>network.<br><br>- make sure speech codec (choosen) is only included on AoIP based<br>  networks<br><br>Change-Id: Ic7f28aacc953d96ebf3aa04f3e1810475458c1a8<br>---<br>M src/osmo-bsc/assignment_fsm.c<br>1 file changed, 8 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c</span><br><span>index 63776f0..5304d6c 100644</span><br><span>--- a/src/osmo-bsc/assignment_fsm.c</span><br><span>+++ b/src/osmo-bsc/assignment_fsm.c</span><br><span>@@ -165,10 +165,14 @@</span><br><span>                         addr_local_p = &addr_local;</span><br><span>              }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           /* Extrapolate speech codec from speech mode */</span><br><span style="color: hsl(0, 100%, 40%);">-         /* FIXME: AMR codec configuration must be derived from lchan1! */</span><br><span style="color: hsl(0, 100%, 40%);">-               gsm0808_speech_codec_from_chan_type(&sc, perm_spch);</span><br><span style="color: hsl(0, 100%, 40%);">-                sc_ptr = &sc;</span><br><span style="color: hsl(120, 100%, 40%);">+             /* Only AoIP networks include a speech codec (choosen) in the</span><br><span style="color: hsl(120, 100%, 40%);">+          * assignment complete message. */</span><br><span style="color: hsl(120, 100%, 40%);">+            if (gscon_is_aoip(conn)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    /* Extrapolate speech codec from speech mode */</span><br><span style="color: hsl(120, 100%, 40%);">+                       /* FIXME: AMR codec configuration must be derived from lchan1! */</span><br><span style="color: hsl(120, 100%, 40%);">+                     gsm0808_speech_codec_from_chan_type(&sc, perm_spch);</span><br><span style="color: hsl(120, 100%, 40%);">+                      sc_ptr = &sc;</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span>    }</span><br><span> </span><br><span>        resp = gsm0808_create_ass_compl(lchan->abis_ip.ass_compl.rr_cause,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11059">change 11059</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11059"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ic7f28aacc953d96ebf3aa04f3e1810475458c1a8 </div>
<div style="display:none"> Gerrit-Change-Number: 11059 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>