<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11076">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: omit HIDDEN from vty reference<br><br>During 'show online help', the XML vty node dump, omit all commands marked<br>HIDDEN.<br><br>These commands were already hidden from the VTY reference prior to commit<br>I1f18e0e41da4772d092d71261b9e489dc1598923, because of broken/confusing bit and<br>boolean logic mixup. After that commit, HIDDEN commands end up in the doc.  So<br>practically, this patch here brings back the status quo of before above commit,<br>even though the previous code clearly "intended" to list HIDDEN commands in the<br>reference but failed to have that effect.<br><br>AFAICT the complete list of commands currently hidden is:<br><br>* osmo-bsc: bts/"training_sequence_code <0-7>",<br>* osmo-bsc: ts/"phys_chan_config PCHAN" for uppercase pchans;<br>* osmo-bts: bts/"rtp bind-ip A.B.C.D" which actually says<br>  vty_out(vty, "%% rtp bind-ip is now deprecated%s", VTY_NEWLINE);<br>* osmo-sgsn: 'reset sgsn state' used for SGSN testing.<br><br>Note that the osmo-sgsn build was broken by including hidden commands in the<br>vty reference, since one of its hidden commands had missing doc strings and<br>made osmotestconfig.py signal failure. This would fix that from the<br>hide-hidden-commands angle, and so would osmo-sgsn commit<br>I8b6e8615e409266910f2f76a10ced9ab33e4de91 from the fix-the-doc-strings angle.<br><br>Change-Id: I92c3c66ff69c186234276c64478d6342e061d25e<br>---<br>M src/vty/command.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/command.c b/src/vty/command.c</span><br><span>index 1e77d13..a540cd5 100644</span><br><span>--- a/src/vty/command.c</span><br><span>+++ b/src/vty/command.c</span><br><span>@@ -679,7 +679,7 @@</span><br><span>                    elem = vector_slot(cnode->cmd_vector, j);</span><br><span>                         if (!vty_command_is_common(elem))</span><br><span>                            continue;</span><br><span style="color: hsl(0, 100%, 40%);">-                       if (!(elem->attr & CMD_ATTR_DEPRECATED))</span><br><span style="color: hsl(120, 100%, 40%);">+                       if (!(elem->attr & (CMD_ATTR_DEPRECATED | CMD_ATTR_HIDDEN)))</span><br><span>                          vty_dump_element(elem, vty);</span><br><span>                 }</span><br><span>    }</span><br><span>@@ -717,7 +717,7 @@</span><br><span>                      elem = vector_slot(cnode->cmd_vector, j);</span><br><span>                         if (vty_command_is_common(elem))</span><br><span>                             continue;</span><br><span style="color: hsl(0, 100%, 40%);">-                       if (!(elem->attr & CMD_ATTR_DEPRECATED))</span><br><span style="color: hsl(120, 100%, 40%);">+                       if (!(elem->attr & (CMD_ATTR_DEPRECATED | CMD_ATTR_HIDDEN)))</span><br><span>                          vty_dump_element(elem, vty);</span><br><span>                 }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11076">change 11076</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11076"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I92c3c66ff69c186234276c64478d6342e061d25e </div>
<div style="display:none"> Gerrit-Change-Number: 11076 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>