<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11070">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty reference: fix deprecation bit evaluation<br><br>In vty_dump_nodes(), make sure the bitwise & is evaluated first.<br><br>For the deprecation flag (0x1), the practical effect is most likely identical,<br>assuming that the boolean ! operator flips the first bit, so I expect no<br>visible functional difference. It still was confusing and wrong to look at.<br><br>Related: OS#3584<br>Change-Id: I1f18e0e41da4772d092d71261b9e489dc1598923<br>---<br>M src/vty/command.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/70/11070/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/command.c b/src/vty/command.c</span><br><span>index 43f974c..900680f 100644</span><br><span>--- a/src/vty/command.c</span><br><span>+++ b/src/vty/command.c</span><br><span>@@ -679,7 +679,7 @@</span><br><span>                    elem = vector_slot(cnode->cmd_vector, j);</span><br><span>                         if (!vty_command_is_common(elem))</span><br><span>                            continue;</span><br><span style="color: hsl(0, 100%, 40%);">-                       if (!elem->attr & CMD_ATTR_DEPRECATED)</span><br><span style="color: hsl(120, 100%, 40%);">+                 if (!(elem->attr & CMD_ATTR_DEPRECATED))</span><br><span>                              vty_dump_element(elem, vty);</span><br><span>                 }</span><br><span>    }</span><br><span>@@ -717,7 +717,7 @@</span><br><span>                      elem = vector_slot(cnode->cmd_vector, j);</span><br><span>                         if (vty_command_is_common(elem))</span><br><span>                             continue;</span><br><span style="color: hsl(0, 100%, 40%);">-                       if (!elem->attr & CMD_ATTR_DEPRECATED)</span><br><span style="color: hsl(120, 100%, 40%);">+                 if (!(elem->attr & CMD_ATTR_DEPRECATED))</span><br><span>                              vty_dump_element(elem, vty);</span><br><span>                 }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11070">change 11070</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11070"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1f18e0e41da4772d092d71261b9e489dc1598923 </div>
<div style="display:none"> Gerrit-Change-Number: 11070 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>